refactor: remove deprecated typing uses and add custom linter script#699
Merged
refactor: remove deprecated typing uses and add custom linter script#699
Conversation
cdb4777 to
a39864a
Compare
c21d77d to
85d96fa
Compare
glevco
previously approved these changes
Jul 12, 2023
Codecov Report
@@ Coverage Diff @@
## master #699 +/- ##
==========================================
+ Coverage 84.01% 84.11% +0.09%
==========================================
Files 246 246
Lines 20519 20448 -71
Branches 2769 2760 -9
==========================================
- Hits 17240 17200 -40
+ Misses 2706 2674 -32
- Partials 573 574 +1
|
msbrogli
previously approved these changes
Jul 12, 2023
a39864a to
f5c3905
Compare
85d96fa to
acb0972
Compare
33abcac to
ba13778
Compare
The base branch was changed.
acb0972 to
b0672bc
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
I noticed some uses of
typing.Setin the code, even after we removing those, because there's no linter it's very easy to forget we can usesetinstead.Acceptance Criteria
Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged