Conversation
80d4fc3 to
75a81bf
Compare
Codecov Report
@@ Coverage Diff @@
## master #697 +/- ##
==========================================
- Coverage 84.13% 84.01% -0.12%
==========================================
Files 246 246
Lines 20450 20519 +69
Branches 2760 2769 +9
==========================================
+ Hits 17206 17240 +34
- Misses 2672 2706 +34
- Partials 572 573 +1
|
jansegre
previously approved these changes
Jul 12, 2023
jansegre
approved these changes
Jul 12, 2023
glevco
reviewed
Jul 12, 2023
pedroferreira1
approved these changes
Jul 12, 2023
3695ad2 to
78123f0
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR contains refactors needed by sync v2. These changes DO NOT change any external behavior. They are mostly adjustments and fixes so tests can be easily adapted to run with sync v2.
Acceptance Criteria
FeatureServiceto gracefully fail and prevent infinite loop.TransactionStorage.get_all_transactions().ConsensusAlgorithm.update().RocksDBHeightIndex._add()method. It was wrongfully identifying a reorg when a reorg wasn't happening.HathorManagerto initialize with partial and invalid transactions stored in the database.@abstractmethoddecorators onSyncManager.FakeConnectionwith an auto-reconnect feature.FakeConnection.reconnect()andFakeConnection.is_both_synced()methods.StopWhenTrue,StopWhenSynced, andAll).TransactionRocksDBStorage. _rocksdb_storage: RocksDBStorage.tests/p2p/test_sync_rate_limiter.pyto run for sync v1 only since it tests a rate limiter that exists only in sync v1.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged