Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #693 +/- ##
==========================================
+ Coverage 84.10% 84.12% +0.01%
==========================================
Files 246 246
Lines 20446 20448 +2
Branches 2759 2759
==========================================
+ Hits 17197 17201 +4
+ Misses 2674 2673 -1
+ Partials 575 574 -1
|
d1f4193 to
02a3548
Compare
02a3548 to
67e0848
Compare
msbrogli
approved these changes
Jul 11, 2023
jansegre
approved these changes
Jul 11, 2023
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR is in preparation for PubSub changes in #694. The current implementation of the
test_p2p_network_events()test,hathor-core/tests/others/test_metrics.py
Lines 68 to 69 in 0dd129d
Tries to start a connection, which fails because the reactor used in tests (
Clock) doesn't support TCP connections. This fail is expected and triggers the emission of the PubSubNETWORK_PEER_CONNECTION_FAILUREevent, which is what triggers theMetricsupdate, making the test work.In #694, the
Clockis getting changed to aMemoryReactorClock, which does support TCP connections (but doesn't complete them), so theNETWORK_PEER_CONNECTION_FAILUREis not triggered.We add an almost effectless new
NETWORK_PEER_CONNECTINGevent that gets triggered when the peers starts connecting, so theMetricsupdate is still triggered.Acceptance Criteria
HathorEvents.NETWORK_PEER_CONNECTINGeventMetricsChecklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged