Skip to content

feat: add get-best-blockchain capability#686

Merged
alexruzenhack merged 13 commits intomasterfrom
feat/add-get-best-blockchain-capability
Jul 28, 2023
Merged

feat: add get-best-blockchain capability#686
alexruzenhack merged 13 commits intomasterfrom
feat/add-get-best-blockchain-capability

Conversation

@alexruzenhack
Copy link
Copy Markdown
Contributor

@alexruzenhack alexruzenhack commented Jun 29, 2023

Acceptance criteria

  • Add capability GET-BEST-BLOCKCHAIN
  • Make the new capability default
  • Add capabilities to HathorProtocol in HelloState
  • Implement commands GET-BEST-BLOCKCHAIN and BEST-BLOCKCHAIN in ReadyState
  • Test all together

Closes:

@alexruzenhack alexruzenhack self-assigned this Jun 29, 2023
@alexruzenhack alexruzenhack added the enhancement New feature or request label Jun 29, 2023
@alexruzenhack alexruzenhack marked this pull request as draft June 29, 2023 00:06
@alexruzenhack alexruzenhack force-pushed the feat/add-get-best-blockchain-capability branch from d4d6fc6 to 202fe1d Compare June 29, 2023 00:11
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 29, 2023

Codecov Report

Merging #686 (9ab9d43) into master (e710e6d) will increase coverage by 0.15%.
Report is 1 commits behind head on master.
The diff coverage is 91.35%.

@@            Coverage Diff             @@
##           master     #686      +/-   ##
==========================================
+ Coverage   84.43%   84.59%   +0.15%     
==========================================
  Files         251      252       +1     
  Lines       21607    21686      +79     
  Branches     2923     2936      +13     
==========================================
+ Hits        18244    18345     +101     
+ Misses       2724     2707      -17     
+ Partials      639      634       -5     
Files Changed Coverage Δ
hathor/transaction/block.py 95.35% <ø> (ø)
hathor/p2p/states/utils.py 62.50% <62.50%> (ø)
hathor/p2p/states/ready.py 93.93% <97.50%> (+1.54%) ⬆️
hathor/conf/settings.py 97.16% <100.00%> (+0.08%) ⬆️
hathor/manager.py 82.68% <100.00%> (ø)
hathor/p2p/messages.py 100.00% <100.00%> (ø)
hathor/p2p/protocol.py 93.04% <100.00%> (+0.05%) ⬆️
hathor/p2p/states/hello.py 72.00% <100.00%> (+0.28%) ⬆️
hathor/transaction/storage/transaction_storage.py 92.86% <100.00%> (+0.26%) ⬆️
hathor/types.py 100.00% <100.00%> (ø)

... and 6 files with indirect coverage changes

@alexruzenhack alexruzenhack force-pushed the feat/add-get-best-blockchain-capability branch from 28c0b15 to f92f4c5 Compare July 1, 2023 23:27
@alexruzenhack alexruzenhack requested a review from jansegre July 2, 2023 12:26
@alexruzenhack alexruzenhack force-pushed the feat/add-get-best-blockchain-capability branch from f92f4c5 to 31a409b Compare July 2, 2023 12:45
@alexruzenhack alexruzenhack marked this pull request as ready for review July 2, 2023 14:33
@alexruzenhack alexruzenhack force-pushed the feat/add-get-best-blockchain-capability branch 3 times, most recently from b6bf38a to dfb10ef Compare July 12, 2023 23:52
@alexruzenhack alexruzenhack force-pushed the feat/add-get-best-blockchain-capability branch 3 times, most recently from 32d03de to ff89803 Compare July 18, 2023 18:53
@msbrogli msbrogli force-pushed the feat/add-get-best-blockchain-capability branch from b41bcca to 949d09c Compare July 27, 2023 21:09
@alexruzenhack alexruzenhack force-pushed the feat/add-get-best-blockchain-capability branch from 949d09c to e05fdaf Compare July 27, 2023 21:21
@alexruzenhack alexruzenhack force-pushed the feat/add-get-best-blockchain-capability branch from e05fdaf to 78d3fad Compare July 27, 2023 21:22
jansegre
jansegre previously approved these changes Jul 27, 2023
@alexruzenhack alexruzenhack force-pushed the feat/add-get-best-blockchain-capability branch from 12dac12 to 9ab9d43 Compare July 27, 2023 22:27
@alexruzenhack alexruzenhack requested a review from msbrogli July 27, 2023 22:27
@alexruzenhack alexruzenhack merged commit 126017d into master Jul 28, 2023
@alexruzenhack alexruzenhack deleted the feat/add-get-best-blockchain-capability branch July 28, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants