Skip to content

fix(tests): remove undeeded broken tests#668

Merged
msbrogli merged 1 commit intomasterfrom
fix/remove-sync-checkpoint-test
Jun 15, 2023
Merged

fix(tests): remove undeeded broken tests#668
msbrogli merged 1 commit intomasterfrom
fix/remove-sync-checkpoint-test

Conversation

@jansegre
Copy link
Member

@jansegre jansegre commented Jun 14, 2023

This test broke due to a regression after the latest on_new_tx refactor. However this test isn't actually adding anything right now. This should be reviewed in #648

Acceptance criteria

  • test_checkpoint_validation should be removed
  • all tests should now pass on the CI run

@jansegre jansegre self-assigned this Jun 14, 2023
@jansegre jansegre requested a review from msbrogli as a code owner June 14, 2023 23:16
This test broke due to a regression after the latest on_new_tx refactor.
However this test isn't actually adding anything right now. This should
be reviewed in #648
@jansegre jansegre force-pushed the fix/remove-sync-checkpoint-test branch from 3ff3e20 to 7ac143f Compare June 14, 2023 23:24
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Merging #668 (7ac143f) into master (b0e3509) will increase coverage by 0.00%.
The diff coverage is 81.63%.

@@           Coverage Diff           @@
##           master     #668   +/-   ##
=======================================
  Coverage   83.87%   83.87%           
=======================================
  Files         247      247           
  Lines       20401    20376   -25     
  Branches     2757     2748    -9     
=======================================
- Hits        17111    17091   -20     
+ Misses       2711     2710    -1     
+ Partials      579      575    -4     
Impacted Files Coverage Δ
hathor/p2p/sync_v1/downloader.py 83.33% <ø> (ø)
hathor/manager.py 77.21% <76.92%> (+3.24%) ⬆️
hathor/p2p/manager.py 72.51% <100.00%> (ø)
hathor/p2p/sync_v1/agent.py 85.58% <100.00%> (ø)
hathor/p2p/sync_v1/factory_v1_0.py 100.00% <100.00%> (ø)
hathor/p2p/sync_v1/factory_v1_1.py 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

@msbrogli msbrogli merged commit 7ac143f into master Jun 15, 2023
@msbrogli msbrogli deleted the fix/remove-sync-checkpoint-test branch June 15, 2023 03:43
@jansegre jansegre mentioned this pull request Jul 12, 2023
2 tasks
This was referenced Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants