refactor(init): Remove duplicate code and simplify full verification method#662
Merged
refactor(init): Remove duplicate code and simplify full verification method#662
Conversation
Codecov Report
@@ Coverage Diff @@
## master #662 +/- ##
==========================================
+ Coverage 83.63% 83.78% +0.14%
==========================================
Files 246 246
Lines 20339 20309 -30
Branches 2767 2753 -14
==========================================
+ Hits 17011 17016 +5
+ Misses 2742 2711 -31
+ Partials 586 582 -4
|
jansegre
approved these changes
Jun 14, 2023
msbrogli
force-pushed
the
refactor/init-full-verification
branch
from
ea7b859 to
f772aac
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acceptance criteria
HathorManager._initialize_components()to_initialize_components_full_verification().HathorManager._verify_soft_voided_txs().HathorManager._sync_v2_resume_validations()on_initialize_components_full_verification.