Skip to content

tests(feature-activation): implement reorg test#660

Merged
glevco merged 1 commit intomasterfrom
tests/feature-activation/reorg-test
Jun 20, 2023
Merged

tests(feature-activation): implement reorg test#660
glevco merged 1 commit intomasterfrom
tests/feature-activation/reorg-test

Conversation

@glevco
Copy link
Contributor

@glevco glevco commented Jun 9, 2023

Acceptance Criteria

  • Add signal_bits to block templates
  • Add signal_bits arg to miner simulator
  • Change rule where an error would be raised if trying to retrieve a feature that is only defined in another network
  • Add feature activation reorg test

Resolves #631

@glevco glevco added the tests label Jun 9, 2023
@glevco glevco self-assigned this Jun 9, 2023
@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #660 (bfffecd) into master (6eaedc5) will increase coverage by 0.18%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #660      +/-   ##
==========================================
+ Coverage   83.90%   84.08%   +0.18%     
==========================================
  Files         246      246              
  Lines       20390    20418      +28     
  Branches     2749     2754       +5     
==========================================
+ Hits        17108    17169      +61     
+ Misses       2709     2674      -35     
- Partials      573      575       +2     
Impacted Files Coverage Δ
hathor/manager.py 77.21% <ø> (ø)
hathor/mining/block_template.py 88.46% <ø> (ø)
hathor/feature_activation/feature_service.py 97.22% <100.00%> (ø)
hathor/simulator/miner/geometric_miner.py 100.00% <100.00%> (ø)
hathor/transaction/block.py 92.24% <100.00%> (+0.46%) ⬆️
hathor/transaction/transaction_metadata.py 91.12% <100.00%> (+0.44%) ⬆️

... and 7 files with indirect coverage changes

@glevco glevco force-pushed the feat/feature-activation/caching-mechanism branch from 99c47b4 to 028ee69 Compare June 9, 2023 20:41
@glevco glevco force-pushed the tests/feature-activation/reorg-test branch from da4d721 to 94fcd06 Compare June 9, 2023 20:59
@glevco glevco force-pushed the feat/feature-activation/caching-mechanism branch from 5565046 to eb0c4cf Compare June 16, 2023 16:16
@glevco glevco force-pushed the tests/feature-activation/reorg-test branch 2 times, most recently from 9928561 to 51cb3ee Compare June 16, 2023 17:00
msbrogli
msbrogli previously approved these changes Jun 16, 2023
Base automatically changed from feat/feature-activation/caching-mechanism to master June 16, 2023 21:22
@glevco glevco dismissed msbrogli’s stale review June 16, 2023 21:22

The base branch was changed.

@glevco glevco force-pushed the tests/feature-activation/reorg-test branch from 575ab07 to bfffecd Compare June 16, 2023 21:34
@glevco glevco marked this pull request as ready for review June 16, 2023 21:34
@glevco glevco requested a review from jansegre as a code owner June 16, 2023 21:34
@glevco glevco merged commit 1d5227c into master Jun 20, 2023
@glevco glevco deleted the tests/feature-activation/reorg-test branch June 20, 2023 16:24
@jansegre jansegre mentioned this pull request Jul 12, 2023
2 tasks
This was referenced Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[Feature Activation] Implement dealing with reorgs

3 participants