refactor: migrate all type annotations to PEP 585#654
Merged
Conversation
msbrogli
previously approved these changes
Jun 7, 2023
e8d51ca to
9c9af26
Compare
Codecov Report
@@ Coverage Diff @@
## master #654 +/- ##
==========================================
- Coverage 84.08% 84.04% -0.05%
==========================================
Files 245 245
Lines 20286 20279 -7
Branches 2757 2757
==========================================
- Hits 17057 17043 -14
- Misses 2634 2639 +5
- Partials 595 597 +2
|
msbrogli
previously approved these changes
Jun 9, 2023
glevco
previously approved these changes
Jun 9, 2023
9c9af26 to
dd56e0a
Compare
msbrogli
approved these changes
Jun 9, 2023
glevco
approved these changes
Jun 9, 2023
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor all
List/Dict/...annotations to uselist/dict/...(which don't have to be imported fromtyping). The complete list of types which now allow for such use of[]is on the PEP 585. This is possible because we dropped support for Python 3.8, we had already started to use it in some new annotations but this PR aims to update all the remaining annotations.With the changes of this PR following grep should be empty:
rg -w 'typing.* (List|Dict|Tuple|FrozenSet|Type|AbstractSet|Deque|DefaultDict|OrderedDict)' -t py hathor testsAcceptance Criteria
typingthat now can be done on the original class (instead of the typing class) as described by PEP 585;