refactor: improve manager building on simulator#653
Merged
Conversation
glevco
commented
Jun 6, 2023
Codecov Report
@@ Coverage Diff @@
## master #653 +/- ##
=======================================
Coverage 84.06% 84.07%
=======================================
Files 245 245
Lines 20277 20284 +7
Branches 2758 2757 -1
=======================================
+ Hits 17046 17053 +7
+ Misses 2635 2633 -2
- Partials 596 598 +2
|
msbrogli
approved these changes
Jun 7, 2023
jansegre
approved these changes
Jun 7, 2023
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
Simulator.create_artifacts()Simulator.create_peer()to receive aBuilder, instead of receiving each builder argument and setting themSimulator.get_default_builder()for convenience, keeping the previous default behaviorBuilder.enable_full_verification()andBuilder.disable_full_verification()