fix: send tips rate limit disconnect#650
Merged
alexruzenhack merged 1 commit intomasterfrom Jun 13, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #650 +/- ##
==========================================
+ Coverage 84.04% 84.09% +0.04%
==========================================
Files 245 245
Lines 20275 20291 +16
Branches 2756 2760 +4
==========================================
+ Hits 17041 17064 +23
+ Misses 2637 2631 -6
+ Partials 597 596 -1
|
msbrogli
previously approved these changes
Jun 7, 2023
alexruzenhack
force-pushed
the
fix/p2p-rate-limit-call-later
branch
from
695e0da to
0fd3d93
Compare
jansegre
previously approved these changes
Jun 7, 2023
alexruzenhack
force-pushed
the
fix/p2p-rate-limit-call-later
branch
from
0fd3d93 to
aadc565
Compare
alexruzenhack
force-pushed
the
fix/p2p-rate-limit-call-later
branch
from
aadc565 to
d905a6d
Compare
msbrogli
previously approved these changes
Jun 7, 2023
jansegre
previously approved these changes
Jun 7, 2023
alexruzenhack
force-pushed
the
fix/p2p-rate-limit-call-later
branch
from
c0261bd to
a453734
Compare
jansegre
requested changes
Jun 12, 2023
- refactor: remove delayed call limit - test: wrap _send_tips and assert _send_tips_call_later len - test: verify delayed call is canceled
alexruzenhack
force-pushed
the
fix/p2p-rate-limit-call-later
branch
from
a453734 to
fb2b1b2
Compare
jansegre
approved these changes
Jun 13, 2023
msbrogli
approved these changes
Jun 13, 2023
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/HathorNetwork/on-call-incidents/issues/123.
Acceptance Criteria