Conversation
Codecov Report
@@ Coverage Diff @@
## master #644 +/- ##
==========================================
- Coverage 83.88% 83.86% -0.02%
==========================================
Files 247 247
Lines 20376 20415 +39
Branches 2748 2758 +10
==========================================
+ Hits 17093 17122 +29
- Misses 2709 2711 +2
- Partials 574 582 +8
|
glevco
force-pushed
the
feat/feature-activation/get-endpoint
branch
from
9db398f to
7c0d2f5
Compare
glevco
force-pushed
the
feat/feature-activation/block-ancestor-optimization
branch
from
ab2e73e to
bb2aa75
Compare
msbrogli
previously approved these changes
Jun 5, 2023
glevco
force-pushed
the
feat/feature-activation/get-endpoint
branch
from
7c0d2f5 to
ecd3d89
Compare
glevco
force-pushed
the
feat/feature-activation/block-ancestor-optimization
branch
from
bb2aa75 to
424a933
Compare
jansegre
approved these changes
Jun 7, 2023
glevco
force-pushed
the
feat/feature-activation/get-endpoint
branch
from
ecd3d89 to
f40f182
Compare
glevco
force-pushed
the
feat/feature-activation/block-ancestor-optimization
branch
from
424a933 to
f4aa6df
Compare
glevco
force-pushed
the
feat/feature-activation/get-endpoint
branch
from
f40f182 to
35836ff
Compare
glevco
force-pushed
the
feat/feature-activation/block-ancestor-optimization
branch
from
f4aa6df to
c7639d2
Compare
jansegre
previously approved these changes
Jun 13, 2023
glevco
force-pushed
the
feat/feature-activation/get-endpoint
branch
3 times, most recently
from
f3f3d19 to
659da6d
Compare
glevco
dismissed stale reviews from jansegre and msbrogli
The base branch was changed.
glevco
force-pushed
the
feat/feature-activation/block-ancestor-optimization
branch
from
1c41040 to
1fcc403
Compare
glevco
force-pushed
the
feat/feature-activation/block-ancestor-optimization
branch
from
1fcc403 to
65d53c2
Compare
msbrogli
requested changes
Jun 14, 2023
glevco
force-pushed
the
feat/feature-activation/block-ancestor-optimization
branch
2 times, most recently
from
51355e6 to
723b870
Compare
jansegre
previously approved these changes
Jun 15, 2023
glevco
force-pushed
the
feat/feature-activation/block-ancestor-optimization
branch
from
9c3cea4 to
d931b57
Compare
msbrogli
previously approved these changes
Jun 15, 2023
glevco
force-pushed
the
feat/feature-activation/block-ancestor-optimization
branch
from
d931b57 to
1b1333b
Compare
glevco
force-pushed
the
feat/feature-activation/block-ancestor-optimization
branch
from
1b1333b to
827f003
Compare
msbrogli
approved these changes
Jun 15, 2023
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
FeatureService._get_ancestor_at_height()by using the height index if the block is in the best blockchain.create_peer_artifacts()method on simulatorTransactionStorage.get_transaction_by_height()