Skip to content

refactor: Add common Hathor types#642

Merged
msbrogli merged 1 commit intomasterfrom
refactor/hathor-types-base
Jun 1, 2023
Merged

refactor: Add common Hathor types#642
msbrogli merged 1 commit intomasterfrom
refactor/hathor-types-base

Conversation

@msbrogli
Copy link
Member

@msbrogli msbrogli commented Jun 1, 2023

Acceptance criteria

  1. Create the common Hathor types: TxId, Address, TxOutputScript, Timestamp, TokenUid, and Amount.
  2. Refactor hathor.manager, hathor.transaction.base_transaction, and hathor.transaction.transaction as the initial refactor.

@msbrogli msbrogli requested a review from glevco June 1, 2023 03:18
@msbrogli msbrogli self-assigned this Jun 1, 2023
@msbrogli msbrogli requested a review from jansegre as a code owner June 1, 2023 03:18
@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Merging #642 (a3e3740) into master (c68cc37) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head a3e3740 differs from pull request most recent head e29a919. Consider uploading reports for the commit e29a919 to get more accurate results

@@            Coverage Diff             @@
##           master     #642      +/-   ##
==========================================
+ Coverage   84.03%   84.05%   +0.01%     
==========================================
  Files         244      245       +1     
  Lines       20262    20272      +10     
  Branches     2759     2759              
==========================================
+ Hits        17027    17039      +12     
+ Misses       2637     2635       -2     
  Partials      598      598              
Impacted Files Coverage Δ
hathor/manager.py 69.78% <100.00%> (+0.04%) ⬆️
hathor/transaction/base_transaction.py 91.44% <100.00%> (+0.01%) ⬆️
hathor/transaction/transaction.py 92.68% <100.00%> (+0.02%) ⬆️
hathor/types.py 100.00% <100.00%> (ø)
hathor/util.py 84.59% <100.00%> (+0.65%) ⬆️

... and 3 files with indirect coverage changes

glevco
glevco previously approved these changes Jun 1, 2023
glevco
glevco previously approved these changes Jun 1, 2023
jansegre
jansegre previously approved these changes Jun 1, 2023
@msbrogli msbrogli dismissed stale reviews from jansegre and glevco via 9cd9e2b June 1, 2023 18:28
@msbrogli msbrogli force-pushed the refactor/hathor-types-base branch from e29a919 to 9cd9e2b Compare June 1, 2023 18:28
@msbrogli msbrogli merged commit 9cd9e2b into master Jun 1, 2023
@msbrogli msbrogli deleted the refactor/hathor-types-base branch June 1, 2023 18:30
@jansegre jansegre mentioned this pull request Jul 12, 2023
2 tasks
This was referenced Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants