Skip to content

refactor: implement typed RunNodeArgs#636

Merged
msbrogli merged 1 commit intomasterfrom
refactor/typed-cli-args
Jun 14, 2023
Merged

refactor: implement typed RunNodeArgs#636
msbrogli merged 1 commit intomasterfrom
refactor/typed-cli-args

Conversation

@glevco
Copy link
Contributor

@glevco glevco commented May 29, 2023

Acceptance Criteria

  • Implement new from_namespace() utils function to instantiate typed CLI args from argparse.Namespace
  • Implement new RunNodeArgs named tuple to provide typed run_node CLI args

@glevco glevco self-assigned this May 29, 2023
@glevco glevco requested review from jansegre and msbrogli as code owners May 29, 2023 15:22
@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Merging #636 (3b666d3) into master (ea7b859) will increase coverage by 0.10%.
The diff coverage is 84.04%.

@@            Coverage Diff             @@
##           master     #636      +/-   ##
==========================================
+ Coverage   83.78%   83.89%   +0.10%     
==========================================
  Files         246      247       +1     
  Lines       20309    20401      +92     
  Branches     2753     2757       +4     
==========================================
+ Hits        17016    17115      +99     
+ Misses       2711     2708       -3     
+ Partials      582      578       -4     
Impacted Files Coverage Δ
hathor/transaction/block.py 91.78% <60.00%> (-0.28%) ⬇️
hathor/indexes/deps_index.py 90.56% <66.66%> (+0.18%) ⬆️
hathor/builder/cli_builder.py 73.95% <67.14%> (+0.27%) ⬆️
hathor/manager.py 73.97% <72.72%> (-0.23%) ⬇️
hathor/builder/resources_builder.py 94.39% <95.00%> (+0.16%) ⬆️
hathor/builder/builder.py 92.97% <100.00%> (+0.10%) ⬆️
hathor/consensus/block_consensus.py 94.36% <100.00%> (+0.01%) ⬆️
hathor/consensus/consensus.py 100.00% <100.00%> (ø)
hathor/daa.py 95.49% <100.00%> (ø)
hathor/feature_activation/feature_service.py 96.87% <100.00%> (+0.04%) ⬆️
... and 11 more

... and 3 files with indirect coverage changes

@glevco glevco force-pushed the refactor/typed-cli-args branch from 6f104ee to 1b1978b Compare May 30, 2023 15:23
@glevco glevco requested a review from jansegre May 30, 2023 15:26
@glevco glevco force-pushed the refactor/typed-cli-args branch from 1b1978b to 483db33 Compare June 1, 2023 04:57
@glevco glevco changed the base branch from master to chore/remove-fast-init-beta June 1, 2023 04:59
@glevco glevco marked this pull request as draft June 1, 2023 05:07
Base automatically changed from chore/remove-fast-init-beta to master June 1, 2023 16:54
@glevco glevco force-pushed the refactor/typed-cli-args branch from fee6990 to 4d05da0 Compare June 1, 2023 16:55
@glevco glevco marked this pull request as ready for review June 1, 2023 16:56
@glevco glevco force-pushed the refactor/typed-cli-args branch from 4d05da0 to c5d1a01 Compare June 2, 2023 03:29
jansegre
jansegre previously approved these changes Jun 7, 2023
@glevco glevco force-pushed the refactor/typed-cli-args branch 3 times, most recently from 72838d9 to 1188f6d Compare June 13, 2023 15:28
@glevco glevco requested a review from jansegre June 13, 2023 16:09
jansegre
jansegre previously approved these changes Jun 13, 2023
@glevco glevco force-pushed the refactor/typed-cli-args branch from 1188f6d to 4c54d3c Compare June 13, 2023 18:23
@glevco glevco force-pushed the refactor/typed-cli-args branch from 4c54d3c to c77c655 Compare June 14, 2023 01:16
@glevco glevco force-pushed the refactor/typed-cli-args branch 3 times, most recently from 6630f2b to 3b666d3 Compare June 14, 2023 18:31
@glevco glevco force-pushed the refactor/typed-cli-args branch from 3b666d3 to 5502d83 Compare June 14, 2023 20:05
@msbrogli msbrogli merged commit 5502d83 into master Jun 14, 2023
@msbrogli msbrogli deleted the refactor/typed-cli-args branch June 14, 2023 20:06
@jansegre jansegre mentioned this pull request Jul 12, 2023
2 tasks
This was referenced Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants