Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #636 +/- ##
==========================================
+ Coverage 83.78% 83.89% +0.10%
==========================================
Files 246 247 +1
Lines 20309 20401 +92
Branches 2753 2757 +4
==========================================
+ Hits 17016 17115 +99
+ Misses 2711 2708 -3
+ Partials 582 578 -4
|
jansegre
requested changes
May 30, 2023
6f104ee to
1b1978b
Compare
1b1978b to
483db33
Compare
fee6990 to
4d05da0
Compare
4d05da0 to
c5d1a01
Compare
jansegre
previously approved these changes
Jun 7, 2023
72838d9 to
1188f6d
Compare
jansegre
previously approved these changes
Jun 13, 2023
1188f6d to
4c54d3c
Compare
4c54d3c to
c77c655
Compare
msbrogli
reviewed
Jun 14, 2023
6630f2b to
3b666d3
Compare
msbrogli
approved these changes
Jun 14, 2023
3b666d3 to
5502d83
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
from_namespace()utils function to instantiate typed CLI args fromargparse.NamespaceRunNodeArgsnamed tuple to provide typedrun_nodeCLI args