Skip to content

feat(start): Run the event loop during full node initialization#584

Open
msbrogli wants to merge 3 commits intomasterfrom
feat/event-loop-during-start
Open

feat(start): Run the event loop during full node initialization#584
msbrogli wants to merge 3 commits intomasterfrom
feat/event-loop-during-start

Conversation

@msbrogli
Copy link
Member

@msbrogli msbrogli commented May 9, 2023

Acceptance criteria

  1. Run the event loop during the full node initialization.
  2. Do not block the event loop during tx load.
  3. Do not block the event loop during index initialization.
  4. Make available the HTTP APIs that are safe to run while the full node is loading, namely: DebugLogResource, DebugRaiseResource, DebugRejectResource, DebugPrintResource, DebugCrashResource, DebugMessAroundResource, VersionResource, ProfilerResource, and CPUProfilerResource.
  5. All other HTTP APIs will be available after the full node finishes loading.

@msbrogli msbrogli requested review from glevco and pedroferreira1 May 9, 2023 07:29
@msbrogli msbrogli self-assigned this May 9, 2023
@msbrogli msbrogli requested a review from jansegre as a code owner May 9, 2023 07:29
@msbrogli msbrogli force-pushed the feat/event-loop-during-start branch 7 times, most recently from 2e5a7ff to 5edcee0 Compare May 12, 2023 18:38
@msbrogli msbrogli changed the base branch from master to refactor/resources-builder May 12, 2023 18:39
@msbrogli msbrogli force-pushed the refactor/resources-builder branch from df8918a to c757a5f Compare May 12, 2023 20:05
Base automatically changed from refactor/resources-builder to master May 12, 2023 20:06
@msbrogli msbrogli force-pushed the feat/event-loop-during-start branch 3 times, most recently from 23f5c7f to 93cedd4 Compare May 15, 2023 17:40
@msbrogli msbrogli removed the request for review from glevco May 15, 2023 18:52
@msbrogli msbrogli force-pushed the feat/event-loop-during-start branch 3 times, most recently from 828f19d to 298df42 Compare May 17, 2023 21:57
jansegre
jansegre previously approved these changes May 17, 2023
@msbrogli msbrogli force-pushed the feat/event-loop-during-start branch from 298df42 to c0658b3 Compare May 17, 2023 22:32
jansegre
jansegre previously approved these changes May 18, 2023
@msbrogli msbrogli force-pushed the feat/event-loop-during-start branch from c0658b3 to 4bb6739 Compare June 1, 2023 03:45
@msbrogli msbrogli force-pushed the feat/event-loop-during-start branch from 4bb6739 to a75240d Compare June 7, 2023 07:48
@glevco glevco mentioned this pull request Jul 12, 2023
1 task
@glevco
Copy link
Contributor

glevco commented Jul 12, 2023

@msbrogli just to make it easier for you, I think you'll probably need to change the following lines in this PR:

They're setting the running attribute of a reactor to True after the manager starts. You'll probably need to move this to before start() is called.

@msbrogli msbrogli force-pushed the master branch 2 times, most recently from eb416fa to 21d7909 Compare February 12, 2026 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

3 participants