Skip to content

chore(ci): use GITHUB_SHA env var instead of github.sha #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jansegre merged 1 commit into from
May 3, 2023
Merged

chore(ci): use GITHUB_SHA env var instead of github.sha #579

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion extras/github/docker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ def prep_tags(environ: Dict, base_version: str, is_release_candidate: bool):
SECRETS_GHCR_IMAGE = environ.get('SECRETS_GHCR_IMAGE')

GITHUB_EVENT_NAME = environ.get('GITHUB_EVENT_NAME')
GITHUB_SHA = environ.get('GITHUB_SHA')

import datetime
import re
Expand Down Expand Up @@ -125,7 +126,7 @@ def extract_pyver(filename):
if suffix == default_python:
tags.add('latest')
elif GITHUB_EVENT_NAME == 'push' and not is_release_candidate:
tags.add('sha-' + '${{ github.sha }}'[:8])
tags.add('sha-' + GITHUB_SHA[:8])

# Build the image list and set outputs
output['version'] = version
Expand Down