fix(version): copy the BUILD_VERSION file into the Docker image#576
Merged
fix(version): copy the BUILD_VERSION file into the Docker image#576
Conversation
0d848cf to
e827232
Compare
jansegre
previously approved these changes
Apr 27, 2023
Codecov Report
@@ Coverage Diff @@
## master #576 +/- ##
=======================================
Coverage 83.45% 83.46%
=======================================
Files 221 221
Lines 19144 19101 -43
Branches 2623 2618 -5
=======================================
- Hits 15977 15942 -35
+ Misses 2589 2583 -6
+ Partials 578 576 -2 |
e827232 to
31cd945
Compare
msbrogli
previously approved these changes
Apr 28, 2023
jansegre
reviewed
Apr 28, 2023
jansegre
previously approved these changes
Apr 28, 2023
Co-authored-by: Jan Segre <jan@hathor.network>
31cd945 to
0f056fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
Our built Docker images should contain the BUILD_VERSION file, so they are able to report the injected version when running.
How to test
Build the image with
docker build -t local/hathor-core .Run it with
docker run -it local/hathor-core run_nodeThe first log should contain the right version.
-localprefix.