Skip to content

fix(version): copy the BUILD_VERSION file into the Docker image#576

Merged
jansegre merged 1 commit intomasterfrom
fix/build-version-dockerfile
May 3, 2023
Merged

fix(version): copy the BUILD_VERSION file into the Docker image#576
jansegre merged 1 commit intomasterfrom
fix/build-version-dockerfile

Conversation

@luislhl
Copy link
Copy Markdown
Contributor

@luislhl luislhl commented Apr 27, 2023

Acceptance Criteria

Our built Docker images should contain the BUILD_VERSION file, so they are able to report the injected version when running.

How to test

  1. Create a BUILD_VERSION file in your local repo:
cat <<EOF > BUILD_VERSION                         
1.2.3
EOF
  1. Build the image with docker build -t local/hathor-core .

  2. Run it with docker run -it local/hathor-core run_node

The first log should contain the right version.

  1. Remove the BUILD_VERSION file and build and run the image again. The version should now contain the -local prefix.

@luislhl luislhl self-assigned this Apr 27, 2023
@luislhl luislhl force-pushed the fix/build-version-dockerfile branch from 0d848cf to e827232 Compare April 27, 2023 21:48
@luislhl luislhl changed the base branch from release-candidate to master April 27, 2023 21:48
jansegre
jansegre previously approved these changes Apr 27, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 27, 2023

Codecov Report

Merging #576 (31cd945) into master (bfd6e04) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 31cd945 differs from pull request most recent head 0f056fc. Consider uploading reports for the commit 0f056fc to get more accurate results

@@           Coverage Diff           @@
##           master     #576   +/-   ##
=======================================
  Coverage   83.45%   83.46%           
=======================================
  Files         221      221           
  Lines       19144    19101   -43     
  Branches     2623     2618    -5     
=======================================
- Hits        15977    15942   -35     
+ Misses       2589     2583    -6     
+ Partials      578      576    -2     

see 8 files with indirect coverage changes

@luislhl luislhl removed the request for review from msbrogli April 28, 2023 02:28
@luislhl luislhl force-pushed the fix/build-version-dockerfile branch from e827232 to 31cd945 Compare April 28, 2023 17:08
@luislhl luislhl requested a review from msbrogli April 28, 2023 19:27
msbrogli
msbrogli previously approved these changes Apr 28, 2023
jansegre
jansegre previously approved these changes Apr 28, 2023
Co-authored-by: Jan Segre <jan@hathor.network>
@jansegre jansegre dismissed stale reviews from msbrogli and themself via 0f056fc May 3, 2023 13:58
@jansegre jansegre force-pushed the fix/build-version-dockerfile branch from 31cd945 to 0f056fc Compare May 3, 2023 13:58
@jansegre jansegre merged commit 38bdb64 into master May 3, 2023
@jansegre jansegre deleted the fix/build-version-dockerfile branch May 3, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants