Skip to content

chore(extras): Fix missing envvar in GitHub extras tests#560

Merged
msbrogli merged 1 commit intomasterfrom
chore/fix-extras-github-tests
Apr 22, 2023
Merged

chore(extras): Fix missing envvar in GitHub extras tests#560
msbrogli merged 1 commit intomasterfrom
chore/fix-extras-github-tests

Conversation

@msbrogli
Copy link
Copy Markdown
Member

@msbrogli msbrogli commented Apr 20, 2023

Acceptance criteria

  1. Set envvar GITHUB_REPOSITORY as hathornetwork/hathor-core for tests. This fixes some tests failures when running on a fork repository.

@msbrogli msbrogli self-assigned this Apr 20, 2023
@msbrogli msbrogli requested a review from jansegre as a code owner April 20, 2023 21:19
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 20, 2023

Codecov Report

Merging #560 (4ce0568) into master (7b2dd3c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #560   +/-   ##
=======================================
  Coverage   83.37%   83.37%           
=======================================
  Files         214      214           
  Lines       18959    18959           
  Branches     2614     2614           
=======================================
  Hits        15808    15808           
  Misses       2580     2580           
  Partials      571      571           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@msbrogli msbrogli merged commit 4ce0568 into master Apr 22, 2023
@msbrogli msbrogli deleted the chore/fix-extras-github-tests branch April 22, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants