refactor(builder): Change HathorManager.__init__ and change tests to use TestBuilder#559
refactor(builder): Change HathorManager.__init__ and change tests to use TestBuilder#559
Conversation
2cfdfe4 to
da73891
Compare
2d6c65c to
232319f
Compare
Codecov Report
@@ Coverage Diff @@
## dev #559 +/- ##
==========================================
+ Coverage 83.30% 83.35% +0.04%
==========================================
Files 212 214 +2
Lines 18729 18959 +230
Branches 2596 2614 +18
==========================================
+ Hits 15603 15803 +200
- Misses 2561 2582 +21
- Partials 565 574 +9
... and 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jansegre
left a comment
There was a problem hiding this comment.
Functionally I'm more than OK with this PR, I really like the direction we're going with the Builder. I only have some smaller naming and behavior suggestions.
f3ed01a to
ed092c6
Compare
glevco
left a comment
There was a problem hiding this comment.
Like Jan, I like this direction and I only have minor comments. Moving CliBuilder to this solution soon would be great.
1f84f43 to
21148fa
Compare
21148fa to
7b2dd3c
Compare
Acceptance criteria
peer_id,tx_storage, andnetworkrequired onHathorManager.__init__(...).TestBuilderto build all objects for tests.TestBuilder.Note: I was considering to refactor
CliBuilderto useBuilderbut I felt it was too much for now. Besides that, I don't need to change theCliBuilderto move forward with my project.