refactor(builder): HathorManager stops building ConsensusAlgorithm itself#558
Merged
refactor(builder): HathorManager stops building ConsensusAlgorithm itself#558
Conversation
msbrogli
changed the title
msbrogli
force-pushed
the
refactor/build-consensus
branch
2 times, most recently
from
929384e to
6b2ccdd
Compare
msbrogli
force-pushed
the
refactor/build-consensus
branch
from
6b2ccdd to
2859617
Compare
Codecov Report
@@ Coverage Diff @@
## dev #558 +/- ##
==========================================
+ Coverage 83.26% 83.30% +0.04%
==========================================
Files 212 212
Lines 18723 18729 +6
Branches 2595 2596 +1
==========================================
+ Hits 15589 15603 +14
+ Misses 2566 2561 -5
+ Partials 568 565 -3
... and 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
glevco
approved these changes
Apr 18, 2023
jansegre
approved these changes
Apr 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acceptance criteria
ConsensusAlgorithmobject outside ofHathorManager.HathorManagerto require aConsensusAlgorithmobject.HathorManager.soft_voided_tx_idsattribute.