Skip to content

fix: handle missing git command when getting local version #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luislhl merged 1 commit into from
Apr 17, 2023
Merged

fix: handle missing git command when getting local version #557

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions hathor/version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,9 @@ def _get_build_version() -> Optional[str]:
def _get_git_revision_short_hash() -> Optional[str]:
try:
return subprocess.check_output(['git', 'rev-parse', '--short', 'HEAD']).decode('ascii').strip()
except subprocess.CalledProcessError:
except (subprocess.CalledProcessError, FileNotFoundError):
logger.warn((
"Error while trying to get local git head. We are probably not in a git repo. "
"Error while trying to get local git head. There is either no git available or we aren't in a git repo. "
"Will report local version without any git info."
))
return None
Expand Down