feat: add best_block and best_block_tips to dag on status#549
Merged
alexruzenhack merged 6 commits intodevfrom Apr 5, 2023
Merged
feat: add best_block and best_block_tips to dag on status#549alexruzenhack merged 6 commits intodevfrom
alexruzenhack merged 6 commits intodevfrom
Conversation
alexruzenhack
force-pushed
the
feat/dag-best-block
branch
from
7a7a2d0 to
47c1617
Compare
alexruzenhack
force-pushed
the
feat/dag-best-block
branch
from
47c1617 to
3480cd5
Compare
luislhl
reviewed
Apr 4, 2023
luislhl
reviewed
Apr 4, 2023
Codecov Report
@@ Coverage Diff @@
## dev #549 +/- ##
=======================================
Coverage 83.21% 83.21%
=======================================
Files 211 211
Lines 18659 18665 +6
Branches 2592 2593 +1
=======================================
+ Hits 15527 15532 +5
Misses 2563 2563
- Partials 569 570 +1
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
luislhl
approved these changes
Apr 4, 2023
jansegre
approved these changes
Apr 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This addition will allow the hathor-p2p-monitor to monitor synchronization with sync-v2 peers in a simplified way.
Ref.: https://github.com/HathorNetwork/hathor-p2p-monitor/pull/69
Acceptance criteria
best_blockandbest_block_tipsto dag property of/status