Skip to content

ci: adapt to the new release process#547

Merged
luislhl merged 1 commit intodevfrom
ci/new-release-process
Apr 19, 2023
Merged

ci: adapt to the new release process#547
luislhl merged 1 commit intodevfrom
ci/new-release-process

Conversation

@luislhl
Copy link
Copy Markdown
Contributor

@luislhl luislhl commented Mar 29, 2023

Acceptance Criteria

  • Disable caching of Docker layers when building nightly builds
  • Write the BUILD_VERSION file with the version that was just built. This should be done only for nigthly, release-candidate and release builds.
  • For the release-candidate, we should only build a Docker image for the default Python version (currently 3.9), and it should have only the main tag on it, not the tags for specific python versions/implementations)
  • We should send messages to Slack for builds of release-candidate and release images, but only for the default python version in our version matrix. Otherwise we would be sending many alerts at once.
  • Fix a previous error in the workflow where we were apparently making comparisons like if: steps.prep.outputs.login-dockerhub, but we were assign the value 'false' to these variables, which is a truthy value.
  • We should have a guide about how to use https://github.com/nektos/act to test our Github Actions workflow

Notes

I'll be proposing a refactoring on this in a new PR (#548) to extract these Python script into actual Python files, because they are becoming too hard to maintain.

Then we will just call the scripts from the workflow and we will be able to have unit tests for them.

TODO

  • Create the Slack secrets in the repo

@luislhl luislhl self-assigned this Mar 29, 2023
@luislhl luislhl removed request for jansegre and msbrogli March 29, 2023 20:53
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 29, 2023

Codecov Report

Merging #547 (25997fe) into dev (2859617) will decrease coverage by 0.06%.
The diff coverage is n/a.

❗ Current head 25997fe differs from pull request most recent head 79a4717. Consider uploading reports for the commit 79a4717 to get more accurate results

@@            Coverage Diff             @@
##              dev     #547      +/-   ##
==========================================
- Coverage   83.31%   83.26%   -0.06%     
==========================================
  Files         212      212              
  Lines       18729    18723       -6     
  Branches     2596     2595       -1     
==========================================
- Hits        15605    15590      -15     
- Misses       2560     2566       +6     
- Partials      564      567       +3     

see 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@luislhl luislhl force-pushed the ci/new-release-process branch from 0231886 to e4eeb93 Compare March 30, 2023 18:16
@luislhl luislhl changed the base branch from dev to feat/allow-version-override March 30, 2023 18:16
@luislhl luislhl force-pushed the ci/new-release-process branch from 340da9c to 6ab35a7 Compare March 30, 2023 19:14
@luislhl luislhl force-pushed the feat/allow-version-override branch from 639cb2b to e96364d Compare March 30, 2023 19:17
@luislhl luislhl force-pushed the ci/new-release-process branch from 6ab35a7 to dd8dcad Compare March 30, 2023 19:20
@luislhl luislhl force-pushed the feat/allow-version-override branch from e96364d to 0903a8e Compare March 31, 2023 14:03
@luislhl luislhl force-pushed the ci/new-release-process branch from 15aa10d to f26b5d2 Compare March 31, 2023 14:04
@luislhl luislhl requested review from jansegre and msbrogli March 31, 2023 15:52
@luislhl luislhl force-pushed the ci/new-release-process branch from ffc4266 to e018be0 Compare April 5, 2023 14:55
@luislhl luislhl force-pushed the feat/allow-version-override branch from eaa06ed to b2e164b Compare April 12, 2023 19:30
@luislhl luislhl force-pushed the ci/new-release-process branch from 4c9cf9c to 903a188 Compare April 12, 2023 19:37
Base automatically changed from feat/allow-version-override to dev April 17, 2023 12:32
@luislhl luislhl force-pushed the ci/new-release-process branch 4 times, most recently from 1bfac39 to c51feed Compare April 19, 2023 16:30
@luislhl luislhl force-pushed the ci/new-release-process branch from c51feed to 79a4717 Compare April 19, 2023 16:34
@luislhl luislhl merged commit 3a33c24 into dev Apr 19, 2023
@luislhl luislhl deleted the ci/new-release-process branch April 19, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants