Conversation
Codecov Report
@@ Coverage Diff @@
## dev #547 +/- ##
==========================================
- Coverage 83.31% 83.26% -0.06%
==========================================
Files 212 212
Lines 18729 18723 -6
Branches 2596 2595 -1
==========================================
- Hits 15605 15590 -15
- Misses 2560 2566 +6
- Partials 564 567 +3 see 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
0231886 to
e4eeb93
Compare
340da9c to
6ab35a7
Compare
639cb2b to
e96364d
Compare
6ab35a7 to
dd8dcad
Compare
e96364d to
0903a8e
Compare
15aa10d to
f26b5d2
Compare
luislhl
commented
Mar 31, 2023
jansegre
reviewed
Apr 4, 2023
ffc4266 to
e018be0
Compare
jansegre
approved these changes
Apr 5, 2023
msbrogli
requested changes
Apr 12, 2023
eaa06ed to
b2e164b
Compare
4c9cf9c to
903a188
Compare
msbrogli
approved these changes
Apr 14, 2023
1bfac39 to
c51feed
Compare
c51feed to
79a4717
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
nightlybuildsnigthly,release-candidateandreleasebuilds.release-candidate, we should only build a Docker image for the default Python version (currently 3.9), and it should have only the main tag on it, not the tags for specific python versions/implementations)release-candidateandreleaseimages, but only for the default python version in our version matrix. Otherwise we would be sending many alerts at once.if: steps.prep.outputs.login-dockerhub, but we were assign the value'false'to these variables, which is a truthy value.Notes
I'll be proposing a refactoring on this in a new PR (#548) to extract these Python script into actual Python files, because they are becoming too hard to maintain.
Then we will just call the scripts from the workflow and we will be able to have unit tests for them.
TODO