Skip to content

ci: add commit sha on nigthly image tags#545

Merged
luislhl merged 1 commit intodevfrom
ci/add-commit-sha-on-nightlies
Mar 29, 2023
Merged

ci: add commit sha on nigthly image tags#545
luislhl merged 1 commit intodevfrom
ci/add-commit-sha-on-nightlies

Conversation

@luislhl
Copy link
Copy Markdown
Contributor

@luislhl luislhl commented Mar 27, 2023

Acceptance Criteria

  • Add the git commit sha in nightly Docker images tag

Notes

For the schedule event, which is the one we use to build nightlies, the commit sha of the default branch is the one included in the build context: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#schedule

This is enough for us, since we will always build nightlies from the default branch.

@luislhl luislhl force-pushed the ci/add-commit-sha-on-nightlies branch from 5b841c1 to 63c53d7 Compare March 27, 2023 18:26
@luislhl luislhl self-assigned this Mar 27, 2023
@luislhl luislhl changed the title ci: add commit sha on nigthly images ci: add commit sha on nigthly image tags Mar 27, 2023
@luislhl luislhl marked this pull request as ready for review March 28, 2023 16:49
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 28, 2023

Codecov Report

Merging #545 (63c53d7) into dev (adc0ac5) will increase coverage by 0.01%.
The diff coverage is 88.23%.

@@            Coverage Diff             @@
##              dev     #545      +/-   ##
==========================================
+ Coverage   83.20%   83.21%   +0.01%     
==========================================
  Files         211      211              
  Lines       18646    18658      +12     
  Branches     2590     2592       +2     
==========================================
+ Hits        15514    15527      +13     
+ Misses       2563     2562       -1     
  Partials      569      569              
Impacted Files Coverage Δ
hathor/event/model/base_event.py 92.30% <ø> (ø)
hathor/pubsub.py 94.73% <ø> (-0.20%) ⬇️
hathor/event/event_manager.py 94.87% <84.61%> (-2.15%) ⬇️
hathor/builder.py 78.96% <100.00%> (+0.52%) ⬆️
hathor/manager.py 70.13% <100.00%> (+0.08%) ⬆️

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@luislhl luislhl merged commit bae3a7e into dev Mar 29, 2023
@luislhl luislhl deleted the ci/add-commit-sha-on-nightlies branch March 29, 2023 16:41
luislhl added a commit that referenced this pull request Mar 30, 2023
luislhl added a commit that referenced this pull request Mar 30, 2023
luislhl added a commit that referenced this pull request Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants