Conversation
Codecov Report
@@ Coverage Diff @@
## dev #543 +/- ##
=======================================
Coverage 83.22% 83.22%
=======================================
Files 211 211
Lines 18673 18673
Branches 2593 2593
=======================================
Hits 15541 15541
Misses 2564 2564
Partials 568 568 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jansegre
approved these changes
Mar 28, 2023
f91c155 to
6b5bbb3
Compare
6b5bbb3 to
356fe0b
Compare
msbrogli
approved these changes
Apr 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the way
EventManagertransmits events. Instead of passingHathorEventsfromPubSubdirectly to theEventStorageand the client WebSocket, it now converts the events to a newEventTypeenum that has been created.This allows for decoupling event types between internal events published via
PubSuband what we actually want to expose as an interface to our clients, clearing up confusion related to event names and improving proximity to what was described in the original design. This also allowed bringing back events that were previously removed, as they are now separate events mapped fromPubSubevents.Acceptance Criteria:
EventTypeenum replacesHathorEventsas the type forBaseEventLOAD_STARTEDevent has been brought back, but mapped from existingMANAGER_ON_STARTevent fromPubSub.NEW_VERTEX_ACCEPTEDis now emitted instead ofNETWORK_NEW_TX_ACCEPTED, as it's mapped from it.