Skip to content

refactor(indexes): move interest scope to inside the index#538

Merged
jansegre merged 3 commits intodevfrom
refactor/indexes-scope
Mar 9, 2023
Merged

refactor(indexes): move interest scope to inside the index#538
jansegre merged 3 commits intodevfrom
refactor/indexes-scope

Conversation

@jansegre
Copy link
Copy Markdown
Member

@jansegre jansegre commented Mar 6, 2023

Acceptance Criteria

  • replace hathor.indexes.manager._IndexFilter with hathor.indexes.base_index.Scope, making the indexes themselves report the scope of transactions they're interested in
  • do not alter any behavior other than exposing the deps-indexes to partial transactions
  • reduce rate of tests/tx/test_stratum.py failing because of running in parallel and listening on the same port

@jansegre jansegre requested a review from msbrogli as a code owner March 6, 2023 19:38
@jansegre jansegre self-assigned this Mar 6, 2023
@jansegre jansegre force-pushed the refactor/indexes-scope branch from 91f05d1 to 28184bb Compare March 6, 2023 19:39
@jansegre jansegre force-pushed the refactor/indexes-scope branch from 28184bb to 7c7c072 Compare March 6, 2023 19:45
@jansegre jansegre force-pushed the refactor/indexes-scope branch from 7c7c072 to 274b275 Compare March 6, 2023 20:43
@jansegre jansegre requested a review from glevco March 7, 2023 16:25
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 8, 2023

Codecov Report

Merging #538 (24038b9) into dev (42bfc1c) will increase coverage by 0.08%.
The diff coverage is 93.95%.

@@            Coverage Diff             @@
##              dev     #538      +/-   ##
==========================================
+ Coverage   83.11%   83.20%   +0.08%     
==========================================
  Files         209      211       +2     
  Lines       18512    18646     +134     
  Branches     2587     2590       +3     
==========================================
+ Hits        15386    15514     +128     
- Misses       2560     2562       +2     
- Partials      566      570       +4     
Impacted Files Coverage Δ
hathor/builder.py 78.43% <ø> (+0.78%) ⬆️
hathor/manager.py 70.04% <ø> (-0.05%) ⬇️
hathor/transaction/storage/rocksdb_storage.py 92.70% <40.00%> (-2.04%) ⬇️
hathor/indexes/scope.py 75.67% <75.67%> (ø)
hathor/event/model/base_event.py 92.30% <92.30%> (ø)
hathor/indexes/manager.py 92.17% <96.87%> (-0.47%) ⬇️
hathor/event/__init__.py 100.00% <100.00%> (ø)
hathor/event/event_manager.py 97.01% <100.00%> (+2.07%) ⬆️
hathor/event/model/event_data.py 100.00% <100.00%> (ø)
hathor/event/resources/event.py 86.84% <100.00%> (+0.35%) ⬆️
... and 25 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jansegre jansegre requested a review from glevco March 9, 2023 16:22
@jansegre jansegre merged commit adc0ac5 into dev Mar 9, 2023
@jansegre jansegre deleted the refactor/indexes-scope branch March 9, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants