refactor(indexes): move interest scope to inside the index#538
Merged
Conversation
91f05d1 to
28184bb
Compare
28184bb to
7c7c072
Compare
7c7c072 to
274b275
Compare
msbrogli
approved these changes
Mar 7, 2023
glevco
requested changes
Mar 7, 2023
Codecov Report
@@ Coverage Diff @@
## dev #538 +/- ##
==========================================
+ Coverage 83.11% 83.20% +0.08%
==========================================
Files 209 211 +2
Lines 18512 18646 +134
Branches 2587 2590 +3
==========================================
+ Hits 15386 15514 +128
- Misses 2560 2562 +2
- Partials 566 570 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
glevco
approved these changes
Mar 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
hathor.indexes.manager._IndexFilterwithhathor.indexes.base_index.Scope, making the indexes themselves report the scope of transactions they're interested intests/tx/test_stratum.pyfailing because of running in parallel and listening on the same port