feat(parallel-tests): update Makefile to perform tests in parallel#533
feat(parallel-tests): update Makefile to perform tests in parallel#533
Conversation
msbrogli
left a comment
There was a problem hiding this comment.
What was the performance gain in your computer?
|
I just noticed that the codecov wasn't updated (it needs the pytest plugin to run correctly). Maybe it's a one off error, can you check that it wasn't affected and that the codecov still updates correctly? |
ca51a4e to
be3ca5e
Compare
Codecov Report
@@ Coverage Diff @@
## dev #533 +/- ##
==========================================
+ Coverage 83.11% 83.14% +0.02%
==========================================
Files 209 209
Lines 18512 18512
Branches 2587 2587
==========================================
+ Hits 15386 15391 +5
+ Misses 2560 2557 -3
+ Partials 566 564 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@msbrogli I ran In this branch, it takes 18 minutes: |
@jansegre it was probably a one off, it has been updated now |
be3ca5e to
767f1dd
Compare
Thanks for the benchmark. |
c9960ef to
c361c11
Compare
c361c11 to
b316d96
Compare


I noticed that running our tests take a long time, usually more than 1 hour in our CI though GitHub Actions. I tried this simple pytest plugin, pytest-xdist, which parallelizes test runs in multiple CPU cores. It's the main recommended plugin for that purpose, and has more than 1.1k starts on GitHub.
It's hard to get exact statistics on job execution times for a precise benchmark, but from taking a look at previous PRs and comparing with runs on #532, the difference is noticeable. When running locally, on computers with more cores than the GitHub Actions runners, the time gains are even larger.
Acceptance criteria:
pytest-xdistplugin