refactor(manager): Move contructor's parameter wallet_index and utxo_index to builder#504
Merged
refactor(manager): Move contructor's parameter wallet_index and utxo_index to builder#504
Conversation
msbrogli
force-pushed
the
refactor/builder
branch
from
2aefb9c to
38e4709
Compare
msbrogli
force-pushed
the
refactor/builder2
branch
from
a68f8f5 to
2670968
Compare
msbrogli
force-pushed
the
refactor/builder
branch
from
38e4709 to
412b0e8
Compare
msbrogli
force-pushed
the
refactor/builder2
branch
from
2670968 to
5ad4cc9
Compare
Codecov Report
@@ Coverage Diff @@
## dev #504 +/- ##
==========================================
- Coverage 83.26% 83.24% -0.02%
==========================================
Files 186 186
Lines 16864 16862 -2
Branches 2640 2640
==========================================
- Hits 14041 14037 -4
- Misses 2331 2333 +2
Partials 492 492
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
msbrogli
force-pushed
the
refactor/builder2
branch
4 times, most recently
from
d5678c8 to
f75ba58
Compare
msbrogli
force-pushed
the
refactor/builder2
branch
6 times, most recently
from
8a83571 to
079f9c3
Compare
msbrogli
force-pushed
the
refactor/builder2
branch
2 times, most recently
from
8816fe8 to
f1c9cbb
Compare
jansegre
approved these changes
Nov 18, 2022
pedroferreira1
approved these changes
Nov 21, 2022
msbrogli
force-pushed
the
refactor/builder2
branch
from
f1c9cbb to
75c3b59
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
wallet_indexandutxo_indexfromHathorManager's constructor.self.create_peer(...)instead of instantiatingHathorManagerdirectly.TransactionStorage.with_indexattribute as a preparation to move theIndexManagerinstantiation to the builder.