Skip to content

fix(tx): Fix duplicate entries in metadata.conflict_with#250

Merged
msbrogli merged 1 commit intodevfrom
fix/tx-meta-duplicate-conflict-with
Jul 1, 2021
Merged

fix(tx): Fix duplicate entries in metadata.conflict_with#250
msbrogli merged 1 commit intodevfrom
fix/tx-meta-duplicate-conflict-with

Conversation

@msbrogli
Copy link
Member

@msbrogli msbrogli commented Jun 30, 2021

Example of the duplicate entries:

image

@msbrogli msbrogli added the bug Something isn't working label Jun 30, 2021
@msbrogli msbrogli requested a review from jansegre June 30, 2021 23:27
@msbrogli msbrogli self-assigned this Jun 30, 2021
@msbrogli msbrogli force-pushed the fix/tx-meta-duplicate-conflict-with branch from 5e4c703 to 56c3921 Compare June 30, 2021 23:34
@msbrogli msbrogli force-pushed the fix/tx-meta-duplicate-conflict-with branch from 56c3921 to 7a39a5f Compare June 30, 2021 23:48
@codecov-commenter
Copy link

Codecov Report

Merging #250 (7a39a5f) into dev (a4c651e) will decrease coverage by 0.04%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #250      +/-   ##
==========================================
- Coverage   82.35%   82.30%   -0.05%     
==========================================
  Files         148      148              
  Lines       14078    14079       +1     
  Branches     2009     2010       +1     
==========================================
- Hits        11594    11588       -6     
- Misses       2069     2073       +4     
- Partials      415      418       +3     
Impacted Files Coverage Δ
hathor/transaction/transaction_metadata.py 90.44% <33.33%> (+0.56%) ⬆️
hathor/consensus.py 93.10% <100.00%> (-1.34%) ⬇️
hathor/p2p/node_sync.py 83.04% <0.00%> (-0.50%) ⬇️
hathor/p2p/manager.py 68.90% <0.00%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4c651e...7a39a5f. Read the comment docs.

@msbrogli msbrogli merged commit 2464456 into dev Jul 1, 2021
@msbrogli msbrogli deleted the fix/tx-meta-duplicate-conflict-with branch July 1, 2021 01:38
@jansegre jansegre mentioned this pull request Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants