fix(nginx): import correct resource, also improve Makefile#246
Merged
Conversation
msbrogli
approved these changes
Jun 25, 2021
pedroferreira1
approved these changes
Jun 28, 2021
Member
I agree that we should include in the pipeline. We have forgotten to update nginx image more than once. About the public repo I also think it's fine. |
Merged
glevco
added a commit
that referenced
this pull request
May 30, 2025
glevco
added a commit
that referenced
this pull request
Jun 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also I think we should build the nginx docker image with the rest of the pipeline. We mainly use a private ECR repo, but we could use a public GHCR repo. What do you think? @luislhl @msbrogli @pedroferreira1