Skip to content

chore(ci): use codecov for minimum coverage check#234

Merged
jansegre merged 1 commit intodevfrom
chore/codecov-config
Jun 17, 2021
Merged

chore(ci): use codecov for minimum coverage check#234
jansegre merged 1 commit intodevfrom
chore/codecov-config

Conversation

@jansegre
Copy link
Member

This moves the minimum coverage check to codecov. The pipeline will still fail if coverage is not reached, but the tests checks will still pass, this should make it easier to see coverage specific failures.

@jansegre jansegre self-assigned this Jun 16, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #234 (22b3de6) into dev (72b2473) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #234      +/-   ##
==========================================
+ Coverage   83.29%   83.32%   +0.02%     
==========================================
  Files         147      147              
  Lines       14245    14245              
  Branches     1996     1996              
==========================================
+ Hits        11866    11869       +3     
+ Misses       1952     1949       -3     
  Partials      427      427              
Impacted Files Coverage Δ
hathor/transaction/base_transaction.py 93.60% <0.00%> (+0.31%) ⬆️
hathor/wallet/resources/thin_wallet/send_tokens.py 68.96% <0.00%> (+0.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72b2473...22b3de6. Read the comment docs.

@jansegre
Copy link
Member Author

This is what it will look like when a PR fails to reach coverage: jansegre#6

@jansegre jansegre force-pushed the chore/codecov-config branch from 22b3de6 to 2cdf41b Compare June 17, 2021 19:10
@jansegre jansegre merged commit baffa8b into dev Jun 17, 2021
@jansegre jansegre deleted the chore/codecov-config branch June 17, 2021 19:17
@jansegre jansegre mentioned this pull request Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants