feat(p2p): only say the peer is "blocked" when explicitly configured#230
Merged
feat(p2p): only say the peer is "blocked" when explicitly configured#230
Conversation
jansegre
force-pushed
the
feat/adjustable-whitelist-warning
branch
from
92a30d2 to
9f2ef7d
Compare
Codecov Report
@@ Coverage Diff @@
## dev #230 +/- ##
==========================================
- Coverage 83.01% 82.99% -0.02%
==========================================
Files 146 146
Lines 13575 13578 +3
Branches 1913 1914 +1
==========================================
Hits 11269 11269
- Misses 1909 1913 +4
+ Partials 397 396 -1
Continue to review full report at Codecov.
|
hathor/conf/settings.py
Outdated
Member
There was a problem hiding this comment.
This warning is only in the case of a whitelist rejection, right? Maybe we should make this explicit in the comment or in the var name
Member
Author
There was a problem hiding this comment.
What about WHITELIST_WARN_BLOCKED_PEERS?
jansegre
force-pushed
the
feat/adjustable-whitelist-warning
branch
2 times, most recently
from
8c30db3 to
084fbd3
Compare
jansegre
force-pushed
the
feat/adjustable-whitelist-warning
branch
from
084fbd3 to
b6ad701
Compare
msbrogli
approved these changes
Jun 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes it so we have to explicitly enable "peer blocked" warnings. Which should make it so "internal nodes" that don't use the default whitelist don't annoy everyone.