Skip to content

refactor(storage): remove unused async/remote/subprocess methods/storages#228

Merged
jansegre merged 1 commit intodevfrom
refactor/remove-async-storage
Jun 18, 2021
Merged

refactor(storage): remove unused async/remote/subprocess methods/storages#228
jansegre merged 1 commit intodevfrom
refactor/remove-async-storage

Conversation

@jansegre
Copy link
Copy Markdown
Member

No description provided.

@jansegre jansegre self-assigned this Jun 11, 2021
@jansegre jansegre force-pushed the refactor/remove-async-storage branch 2 times, most recently from 9e975a3 to a4dce31 Compare June 11, 2021 06:59
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 11, 2021

Codecov Report

Merging #228 (dd58365) into dev (33efc76) will decrease coverage by 0.32%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #228      +/-   ##
==========================================
- Coverage   83.32%   82.99%   -0.33%     
==========================================
  Files         147      146       -1     
  Lines       14245    13575     -670     
  Branches     1996     1913      -83     
==========================================
- Hits        11869    11267     -602     
+ Misses       1949     1910      -39     
+ Partials      427      398      -29     
Impacted Files Coverage Δ
hathor/transaction/storage/__init__.py 80.00% <ø> (+6.66%) ⬆️
hathor/transaction/storage/binary_storage.py 98.56% <100.00%> (ø)
hathor/transaction/storage/cache_storage.py 98.24% <100.00%> (+0.25%) ⬆️
hathor/transaction/storage/compact_storage.py 96.52% <100.00%> (ø)
hathor/transaction/storage/memory_storage.py 90.90% <100.00%> (ø)
hathor/transaction/storage/rocksdb_storage.py 100.00% <100.00%> (ø)
hathor/transaction/storage/transaction_storage.py 97.57% <100.00%> (+0.81%) ⬆️
hathor/util.py 75.60% <0.00%> (-1.63%) ⬇️
hathor/p2p/manager.py 68.93% <0.00%> (-0.86%) ⬇️
hathor/transaction/base_transaction.py 92.97% <0.00%> (-0.63%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33efc76...dd58365. Read the comment docs.

@jansegre jansegre force-pushed the refactor/remove-async-storage branch from a4dce31 to c6bc198 Compare June 17, 2021 19:22
@jansegre jansegre force-pushed the refactor/remove-async-storage branch from c6bc198 to dd58365 Compare June 17, 2021 22:38
@jansegre jansegre merged commit b2cf4d8 into dev Jun 18, 2021
@jansegre jansegre deleted the refactor/remove-async-storage branch June 18, 2021 02:00
@jansegre jansegre mentioned this pull request Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants