feat(storage): new rocksdb storage with improved performance#189
Merged
feat(storage): new rocksdb storage with improved performance#189
Conversation
jansegre
force-pushed
the
feat/refactor-rocksdb-storage
branch
from
9ec3328 to
b902a50
Compare
jansegre
force-pushed
the
feat/refactor-rocksdb-storage
branch
from
b902a50 to
fae6613
Compare
jansegre
changed the title
pedroferreira1
approved these changes
Jun 17, 2021
jansegre
force-pushed
the
feat/refactor-rocksdb-storage
branch
from
fae6613 to
22bc06b
Compare
jansegre
force-pushed
the
feat/refactor-rocksdb-storage
branch
from
22bc06b to
196f964
Compare
msbrogli
approved these changes
Jun 18, 2021
jansegre
force-pushed
the
feat/refactor-rocksdb-storage
branch
from
196f964 to
ccbf128
Compare
jansegre
force-pushed
the
feat/refactor-rocksdb-storage
branch
from
ccbf128 to
7b9835e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use single rocksdb database with multiple tables (instead of multiple databases), split metadata from tx/block data, and use simpler/faster serialization (struct/json instead of protobuf).
The new storage is created and included in tests but hathor-cli will use the
OldRocksDBStoragewhich is s copy of the old storage, so the changes on this PR cannot break any deploy.