Conversation
|
| Branch | refactor/vertex-parser-package |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.59 m(-7.15%)Baseline: 1.71 m | 1.54 m (96.93%) | 2.05 m (77.37%) |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1597 +/- ##
=========================================
Coverage ? 85.58%
=========================================
Files ? 449
Lines ? 33946
Branches ? 5309
=========================================
Hits ? 29051
Misses ? 3872
Partials ? 1023
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
072a033 to
e449c5f
Compare
eb416fa to
21d7909
Compare
439bf16 to
cb60176
Compare
msbrogli
commented
Feb 13, 2026
r4mmer
reviewed
Feb 13, 2026
jansegre
previously approved these changes
Feb 23, 2026
1ec4873 to
57b1099
Compare
jansegre
previously approved these changes
Feb 23, 2026
r4mmer
previously approved these changes
Feb 24, 2026
57b1099 to
b4c807b
Compare
b4c807b to
056d53e
Compare
056d53e to
0e965cf
Compare
jansegre
approved these changes
Mar 4, 2026
…rtex parser module
0e965cf to
ac98edd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This refactor extracts all binary serialization and deserialization into a dedicated hathor/transaction/vertex_parser/ package, turning vertex classes into pure data containers that delegate to the parser module.
Acceptance Criteria
hathor/transaction/vertex_parser/, organized by vertex type (_block.py, _transaction.py, _token_creation.py, _on_chain_blueprint.py, _common.py)
route to the appropriate type-specific serializer based on TxVersion
but delegate to the vertex parser functions rather than implementing serialization inline
init.py
Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged