Skip to content

chore(dependencies): fix rocksdb dependency#1587

Merged
glevco merged 1 commit intomasterfrom
chore/fix-deps
Feb 2, 2026
Merged

chore(dependencies): fix rocksdb dependency#1587
glevco merged 1 commit intomasterfrom
chore/fix-deps

Conversation

@glevco
Copy link
Contributor

@glevco glevco commented Jan 29, 2026

Motivation

The poetry.lock file has drifted from the correct current version of python-rocksdb. This PR fixes this, and using make fix-rocksdb should not be necessary on local envs anymore.

Acceptance Criteria

  • Set an explicit version for the indirect dependency packaging.
  • Update python-rocksdb in poetry.lock.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this Jan 29, 2026
@glevco glevco moved this from Todo to In Progress (Done) in Hathor Network Jan 29, 2026
@github-actions
Copy link

🐰 Bencher Report

Branchchore/fix-deps
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
minutes (m)
(Result Δ%)
Lower Boundary
minutes (m)
(Limit %)
Upper Boundary
minutes (m)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚷 view threshold
1.60 m
(-6.61%)Baseline: 1.71 m
1.54 m
(96.37%)
2.06 m
(77.82%)
🐰 View full continuous benchmarking report in Bencher

@codecov
Copy link

codecov bot commented Jan 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.73%. Comparing base (b619928) to head (ca9257b).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1587      +/-   ##
==========================================
- Coverage   85.73%   85.73%   -0.01%     
==========================================
  Files         439      439              
  Lines       33767    33767              
  Branches     5277     5277              
==========================================
- Hits        28951    28949       -2     
  Misses       3803     3803              
- Partials     1013     1015       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jansegre
Copy link
Member

Shouldn't this go into python-rocksdb too and then we can remove it from here?

@glevco glevco moved this from In Progress (Done) to In Review (WIP) in Hathor Network Jan 29, 2026
@glevco
Copy link
Contributor Author

glevco commented Jan 29, 2026

@jansegre

Shouldn't this go into python-rocksdb too and then we can remove it from here?

The actual change here is updating the poetry.lock to include the most recent python-rocksdb version, the update to packaging is just a side effect because I couldn't run any poetry commands with the outdated packaging version. So I'm not sure there's anything we could do in the python-rocksdb repo itself.

@glevco glevco moved this from In Review (WIP) to In Review (Done) in Hathor Network Feb 2, 2026
@glevco glevco merged commit 77b2dbd into master Feb 2, 2026
21 of 22 checks passed
@glevco glevco deleted the chore/fix-deps branch February 2, 2026 16:34
@github-project-automation github-project-automation bot moved this from In Review (Done) to Waiting to be deployed in Hathor Network Feb 2, 2026
@jansegre jansegre moved this from Waiting to be deployed to Done in Hathor Network Feb 4, 2026
@jansegre jansegre mentioned this pull request Mar 5, 2026
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants