chore(dependencies): fix rocksdb dependency#1587
Merged
Conversation
|
| Branch | chore/fix-deps |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.60 m(-6.61%)Baseline: 1.71 m | 1.54 m (96.37%) | 2.06 m (77.82%) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1587 +/- ##
==========================================
- Coverage 85.73% 85.73% -0.01%
==========================================
Files 439 439
Lines 33767 33767
Branches 5277 5277
==========================================
- Hits 28951 28949 -2
Misses 3803 3803
- Partials 1013 1015 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jansegre
approved these changes
Jan 29, 2026
Member
|
Shouldn't this go into |
Contributor
Author
The actual change here is updating the |
msbrogli
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
poetry.lockfile has drifted from the correct current version ofpython-rocksdb. This PR fixes this, and usingmake fix-rocksdbshould not be necessary on local envs anymore.Acceptance Criteria
packaging.python-rocksdbinpoetry.lock.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged