Skip to content

test: Fix flaky tests#1581

Merged
msbrogli merged 1 commit intomasterfrom
test/fix-flaky-test_soft_voided
Jan 27, 2026
Merged

test: Fix flaky tests#1581
msbrogli merged 1 commit intomasterfrom
test/fix-flaky-test_soft_voided

Conversation

@msbrogli
Copy link
Copy Markdown
Member

Motivation

What was the motivation for the changes in this PR?

Acceptance Criteria

  • Include here all things that this PR should solve

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@msbrogli msbrogli requested a review from jansegre as a code owner January 27, 2026 22:20
glevco
glevco previously approved these changes Jan 27, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 27, 2026

🐰 Bencher Report

Branchtest/fix-flaky-test_soft_voided
Testbedubuntu-22.04

🚨 1 Alert

BenchmarkMeasure
Units
ViewBenchmark Result
(Result Δ%)
Lower Boundary
(Limit %)
sync-v2 (up to 20000 blocks)Latency
minutes (m)
📈 plot
🚷 threshold
🚨 alert (🔔)
1.37 m
(-20.17%)Baseline: 1.71 m
1.54 m
(112.74%)

Click to view all benchmark results
BenchmarkLatencyBenchmark Result
minutes (m)
(Result Δ%)
Lower Boundary
minutes (m)
(Limit %)
Upper Boundary
minutes (m)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚷 view threshold
🚨 view alert (🔔)
1.37 m
(-20.17%)Baseline: 1.71 m
1.54 m
(112.74%)

2.06 m
(66.52%)
🐰 View full continuous benchmarking report in Bencher

jansegre
jansegre previously approved these changes Jan 27, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.24%. Comparing base (02d339f) to head (6ef1f93).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1581      +/-   ##
==========================================
- Coverage   86.29%   86.24%   -0.05%     
==========================================
  Files         439      439              
  Lines       33724    33724              
  Branches     5280     5280              
==========================================
- Hits        29101    29086      -15     
- Misses       3612     3623      +11     
- Partials     1011     1015       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@msbrogli msbrogli dismissed stale reviews from jansegre and glevco via 0294081 January 27, 2026 23:14
@msbrogli msbrogli force-pushed the test/fix-flaky-test_soft_voided branch from 9eb436d to 0294081 Compare January 27, 2026 23:14
@msbrogli msbrogli changed the title test: Fix flaky hathor_tests/consensus/test_soft_voided.py test: Fix flaky tests Jan 27, 2026
@msbrogli msbrogli force-pushed the test/fix-flaky-test_soft_voided branch from 0294081 to 6ef1f93 Compare January 27, 2026 23:42
@msbrogli msbrogli merged commit 6ef1f93 into master Jan 27, 2026
12 of 13 checks passed
@msbrogli msbrogli deleted the test/fix-flaky-test_soft_voided branch January 27, 2026 23:42
@msbrogli msbrogli self-assigned this Jan 27, 2026
@github-project-automation github-project-automation bot moved this from Todo to Waiting to be deployed in Hathor Network Jan 27, 2026
This was referenced Jan 28, 2026
@jansegre jansegre moved this from Waiting to be deployed to Done in Hathor Network Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants