fix(nano): CallerId name on Blueprint info API#1567
Merged
Conversation
jansegre
approved these changes
Jan 22, 2026
pedroferreira1
approved these changes
Jan 22, 2026
|
| Branch | fix/caller-id-name |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.68 m(-2.26%)Baseline: 1.72 m | 1.55 m (92.08%) | 2.06 m (81.45%) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1567 +/- ##
==========================================
+ Coverage 86.29% 86.31% +0.02%
==========================================
Files 437 437
Lines 33642 33645 +3
Branches 5257 5258 +1
==========================================
+ Hits 29031 29041 +10
+ Misses 3602 3597 -5
+ Partials 1009 1007 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Jan 27, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When blueprints use the
CallerIdtype, the API displays its name as the union and not the type alias.Acceptance Criteria
CallerIdname on blueprint info API to beCallerIdinstead ofUnion[Address, ContractId]Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged