feat(events): add vertex name to events#1558
Merged
Conversation
andreabadesso
previously approved these changes
Jan 19, 2026
jansegre
previously approved these changes
Jan 19, 2026
|
| Branch | feat/vertex-name-on-event |
| Testbed | ubuntu-22.04 |
🚨 1 Alert
| Benchmark | Measure Units | View | Benchmark Result (Result Δ%) | Lower Boundary (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | Latency minutes (m) | 📈 plot 🚷 threshold 🚨 alert (🔔) | 1.40 m(-18.83%)Baseline: 1.72 m | 1.55 m (110.88%) |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold 🚨 view alert (🔔) | 1.40 m(-18.83%)Baseline: 1.72 m | 1.55 m (110.88%) | 2.06 m (67.64%) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1558 +/- ##
==========================================
- Coverage 86.33% 86.25% -0.09%
==========================================
Files 438 438
Lines 33774 33776 +2
Branches 5270 5270
==========================================
- Hits 29159 29133 -26
- Misses 3607 3628 +21
- Partials 1008 1015 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andreabadesso
approved these changes
Jan 19, 2026
jansegre
approved these changes
Jan 19, 2026
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When testing event scenarios created with the dag builder, it would be useful to have vertex names on events.
Acceptance Criteria
nameto tx data on events.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged