Skip to content

feat(dag-builder): add step fn#1555

Merged
glevco merged 1 commit intomasterfrom
feat/step-fn-dag-builder
Jan 21, 2026
Merged

feat(dag-builder): add step fn#1555
glevco merged 1 commit intomasterfrom
feat/step-fn-dag-builder

Conversation

@glevco
Copy link
Contributor

@glevco glevco commented Jan 16, 2026

Motivation

Add ability to run a callback between propagations of the DAG builder.

Acceptance Criteria

  • Add register_step_fn method to artifacts.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this Jan 16, 2026
@glevco glevco moved this from Todo to In Progress (Done) in Hathor Network Jan 16, 2026
@glevco glevco force-pushed the feat/step-fn-dag-builder branch from 612b00e to de3359b Compare January 16, 2026 15:34
@github-actions
Copy link

github-actions bot commented Jan 16, 2026

🐰 Bencher Report

Branchfeat/step-fn-dag-builder
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
minutes (m)
(Result Δ%)
Lower Boundary
minutes (m)
(Limit %)
Upper Boundary
minutes (m)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚷 view threshold
1.68 m
(-2.32%)Baseline: 1.72 m
1.55 m
(92.14%)
2.06 m
(81.40%)
🐰 View full continuous benchmarking report in Bencher

@glevco glevco force-pushed the feat/step-fn-dag-builder branch from de3359b to c32c765 Compare January 16, 2026 15:45
@glevco glevco moved this from In Progress (Done) to In Review (WIP) in Hathor Network Jan 16, 2026
@codecov
Copy link

codecov bot commented Jan 16, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.31%. Comparing base (c78c142) to head (99a54c0).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
hathor/dag_builder/artifacts.py 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1555      +/-   ##
==========================================
+ Coverage   86.29%   86.31%   +0.01%     
==========================================
  Files         437      437              
  Lines       33605    33610       +5     
  Branches     5247     5248       +1     
==========================================
+ Hits        29000    29009       +9     
+ Misses       3597     3596       -1     
+ Partials     1008     1005       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@glevco glevco moved this from In Review (WIP) to In Review (Done) in Hathor Network Jan 20, 2026
@glevco glevco force-pushed the feat/step-fn-dag-builder branch from c32c765 to 99a54c0 Compare January 21, 2026 00:43
@glevco glevco merged commit dae8929 into master Jan 21, 2026
11 of 12 checks passed
@glevco glevco deleted the feat/step-fn-dag-builder branch January 21, 2026 01:14
@github-project-automation github-project-automation bot moved this from In Review (Done) to Waiting to be deployed in Hathor Network Jan 21, 2026
@jansegre jansegre mentioned this pull request Jan 21, 2026
2 tasks
@jansegre jansegre moved this from Waiting to be deployed to Done in Hathor Network Jan 21, 2026
@jansegre jansegre mentioned this pull request Jan 21, 2026
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants