Conversation
3e2983d to
8afc0b1
Compare
|
| Branch | refactor/improve-loading |
| Testbed | ubuntu-22.04 |
🚨 1 Alert
| Benchmark | Measure Units | View | Benchmark Result (Result Δ%) | Lower Boundary (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | Latency minutes (m) | 📈 plot 🚷 threshold 🚨 alert (🔔) | 1.52 m(-11.64%)Baseline: 1.72 m | 1.55 m (101.85%) |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold 🚨 view alert (🔔) | 1.52 m(-11.64%)Baseline: 1.72 m | 1.55 m (101.85%) | 2.06 m (73.64%) |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1549 +/- ##
==========================================
+ Coverage 86.25% 86.30% +0.04%
==========================================
Files 438 438
Lines 33776 33780 +4
Branches 5270 5269 -1
==========================================
+ Hits 29134 29153 +19
+ Misses 3627 3612 -15
Partials 1015 1015 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
msbrogli
requested changes
Jan 12, 2026
9f9133d to
ba0e523
Compare
jansegre
approved these changes
Jan 12, 2026
ba0e523 to
dbf1c5a
Compare
msbrogli
approved these changes
Jan 14, 2026
dbf1c5a to
1681d91
Compare
2 tasks
review changes
1681d91 to
1901010
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
PR #1200 removed sync-v1 indexes, and with that the indexes that require initialization changed. Before, we had indexes interested in blocks, but now we only load the mempool index which is interested in transactions only. This means the Scope iterator skipped a lot of blocks before yielding to the progress log iterator, causing the log to appear stuck for several minutes.
This PR fixes this and also makes some other small improvements on loading logs.
Before:
After:
Acceptance Criteria
Scope.get_iteratorso it yields all txs, not only those that match the scope. It was only used in one place.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged