Merged
Conversation
jansegre
approved these changes
Jan 6, 2026
msbrogli
approved these changes
Jan 6, 2026
|
Bencher Report| Branch | tests/fix-flaky |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.68 m(-3.02%)Baseline: 1.73 m | 1.56 m (92.80%) | 2.08 m (80.82%) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1539 +/- ##
==========================================
+ Coverage 86.26% 86.27% +0.01%
==========================================
Files 437 437
Lines 33731 33732 +1
Branches 5268 5269 +1
==========================================
+ Hits 29098 29103 +5
+ Misses 3621 3618 -3
+ Partials 1012 1011 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-project-automation
bot
moved this from In Review (Done)
to Waiting to be deployed
in Hathor Network
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
test_exceeds_streaming_and_mempool_limitsis extremely flaky, causing a lot of CI fails. This PR fixes this.Acceptance Criteria
iter_transactions_in_this_blockcall on flaky test.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged