refactor(nano): Move the nano execution logic to a separate file#1535
Merged
refactor(nano): Move the nano execution logic to a separate file#1535
Conversation
|
| Branch | refactor/nano-consensus-execution |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.69 m(-1.71%)Baseline: 1.72 m | 1.55 m (91.56%) | 2.06 m (81.91%) |
6a6d233 to
b59c79a
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1535 +/- ##
==========================================
+ Coverage 86.27% 86.34% +0.07%
==========================================
Files 437 439 +2
Lines 33662 33690 +28
Branches 5269 5271 +2
==========================================
+ Hits 29042 29091 +49
+ Misses 3611 3596 -15
+ Partials 1009 1003 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7362549 to
0153848
Compare
jansegre
previously approved these changes
Jan 26, 2026
glevco
previously approved these changes
Jan 26, 2026
0153848 to
ccfe8c6
Compare
This was referenced Jan 27, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR moves the nano execution logic from the Block Consensus Algorithm to a separate file. This is a preparation for upcoming features such as block execution replay and block execution logging.
Acceptance Criteria
NCBlockExecutorto encapsulate nano execution logic.BlockConsensusAlgorithmintoNCBlockExecutor.BlockConsensusAlgorithm.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged