Skip to content

refactor: fix several warnings#1529

Merged
jansegre merged 3 commits intomasterfrom
refactor/fix-several-warnings
Jan 12, 2026
Merged

refactor: fix several warnings#1529
jansegre merged 3 commits intomasterfrom
refactor/fix-several-warnings

Conversation

@jansegre
Copy link
Member

@jansegre jansegre commented Dec 22, 2025

Motivation

Currently there are some warnings about behaviors that will be changed in Python 3.13+ and some usage patterns.

Acceptance Criteria

  • fix asyncioreactor get_running_loop warning
  • replace deprecated cgi module
  • fix datetime.datetime.utcnow deprecation warning
  • turn warnings into errors during tests

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@jansegre jansegre self-assigned this Dec 22, 2025
@jansegre jansegre moved this from Todo to In Progress (WIP) in Hathor Network Dec 22, 2025
@github-actions
Copy link

github-actions bot commented Dec 22, 2025

🐰 Bencher Report

Branchrefactor/fix-several-warnings
Testbedubuntu-22.04

🚨 1 Alert

BenchmarkMeasure
Units
ViewBenchmark Result
(Result Δ%)
Lower Boundary
(Limit %)
sync-v2 (up to 20000 blocks)Latency
minutes (m)
📈 plot
🚷 threshold
🚨 alert (🔔)
1.39 m
(-19.66%)Baseline: 1.73 m
1.55 m
(112.03%)

Click to view all benchmark results
BenchmarkLatencyBenchmark Result
minutes (m)
(Result Δ%)
Lower Boundary
minutes (m)
(Limit %)
Upper Boundary
minutes (m)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚷 view threshold
🚨 view alert (🔔)
1.39 m
(-19.66%)Baseline: 1.73 m
1.55 m
(112.03%)

2.07 m
(66.95%)
🐰 View full continuous benchmarking report in Bencher

@jansegre jansegre force-pushed the refactor/fix-several-warnings branch from 52dd578 to 3c18cfb Compare January 6, 2026 21:54
@jansegre jansegre moved this from In Progress (WIP) to In Progress (Done) in Hathor Network Jan 6, 2026
@jansegre jansegre marked this pull request as ready for review January 6, 2026 21:56
@jansegre jansegre requested a review from msbrogli as a code owner January 6, 2026 21:56
msbrogli
msbrogli previously approved these changes Jan 6, 2026
glevco
glevco previously approved these changes Jan 6, 2026
@github-project-automation github-project-automation bot moved this from In Progress (Done) to In Review (WIP) in Hathor Network Jan 6, 2026
@jansegre jansegre moved this from In Review (WIP) to In Review (Done) in Hathor Network Jan 7, 2026
@jansegre jansegre dismissed stale reviews from glevco and msbrogli via 095e303 January 7, 2026 17:31
@jansegre jansegre force-pushed the refactor/fix-several-warnings branch from 3c18cfb to 095e303 Compare January 7, 2026 17:31
@codecov
Copy link

codecov bot commented Jan 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.24%. Comparing base (6b4b647) to head (ee84245).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1529      +/-   ##
==========================================
- Coverage   86.26%   86.24%   -0.03%     
==========================================
  Files         438      438              
  Lines       33764    33772       +8     
  Branches     5269     5269              
==========================================
  Hits        29127    29127              
- Misses       3622     3628       +6     
- Partials     1015     1017       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jansegre jansegre force-pushed the refactor/fix-several-warnings branch from 095e303 to e3bee38 Compare January 7, 2026 18:40
@jansegre jansegre force-pushed the refactor/fix-several-warnings branch from e3bee38 to ee84245 Compare January 12, 2026 14:46
@github-project-automation github-project-automation bot moved this from In Review (Done) to In Review (WIP) in Hathor Network Jan 12, 2026
@jansegre jansegre merged commit 3ab1510 into master Jan 12, 2026
11 of 12 checks passed
@jansegre jansegre deleted the refactor/fix-several-warnings branch January 12, 2026 15:53
@github-project-automation github-project-automation bot moved this from In Review (WIP) to Waiting to be deployed in Hathor Network Jan 12, 2026
@jansegre jansegre mentioned this pull request Jan 14, 2026
2 tasks
@jansegre jansegre moved this from Waiting to be deployed to Done in Hathor Network Jan 21, 2026
@jansegre jansegre mentioned this pull request Jan 21, 2026
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants