Merged
Conversation
|
| Branch | refactor/fix-several-warnings |
| Testbed | ubuntu-22.04 |
🚨 1 Alert
| Benchmark | Measure Units | View | Benchmark Result (Result Δ%) | Lower Boundary (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | Latency minutes (m) | 📈 plot 🚷 threshold 🚨 alert (🔔) | 1.39 m(-19.66%)Baseline: 1.73 m | 1.55 m (112.03%) |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold 🚨 view alert (🔔) | 1.39 m(-19.66%)Baseline: 1.73 m | 1.55 m (112.03%) | 2.07 m (66.95%) |
52dd578 to
3c18cfb
Compare
msbrogli
previously approved these changes
Jan 6, 2026
glevco
previously approved these changes
Jan 6, 2026
3c18cfb to
095e303
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1529 +/- ##
==========================================
- Coverage 86.26% 86.24% -0.03%
==========================================
Files 438 438
Lines 33764 33772 +8
Branches 5269 5269
==========================================
Hits 29127 29127
- Misses 3622 3628 +6
- Partials 1015 1017 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
095e303 to
e3bee38
Compare
glevco
approved these changes
Jan 7, 2026
e3bee38 to
ee84245
Compare
msbrogli
approved these changes
Jan 12, 2026
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently there are some warnings about behaviors that will be changed in Python 3.13+ and some usage patterns.
Acceptance Criteria
get_running_loopwarningturn warnings into errors during testsChecklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged