feat(nc-history-order): Add order param to NCHistoryResource#1528
feat(nc-history-order): Add order param to NCHistoryResource#1528jansegre merged 3 commits intoHathorNetwork:masterfrom
Conversation
jansegre
left a comment
There was a problem hiding this comment.
Before it can be merged please make sure the linter/tests are passing and include a unittest to hathor_tests/resources/nanocontracts/test_history.py that covers the use of the new param. Other than that it looks good to me.
Ok, Done 👍🏻 |
b442f73 to
fccdc33
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1528 +/- ##
==========================================
- Coverage 86.34% 86.30% -0.05%
==========================================
Files 437 437
Lines 33610 33620 +10
Branches 5248 5248
==========================================
- Hits 29022 29017 -5
- Misses 3586 3598 +12
- Partials 1002 1005 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fccdc33 to
3400c45
Compare
3400c45 to
2b683a8
Compare
Motivation
I currently maintain a database to store only the first Nano Contract history record, which requires manual data insertion. Since this information can be retrieved via the Hathor-Core API, the lack of result ordering in the /nano_contract/history endpoint forces full dataset iteration even when only the first entry is needed, causing unnecessary computational overhead.
Acceptance Criteria