fix(indexes): iterating all mempool transactions could visit every block#1519
Merged
fix(indexes): iterating all mempool transactions could visit every block#1519
Conversation
|
Bencher Report| Branch | fix/iter-mempool-runoff |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.68 m(-2.77%)Baseline: 1.73 m | 1.55 m (92.56%) | 2.07 m (81.03%) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1519 +/- ##
==========================================
+ Coverage 86.25% 86.26% +0.01%
==========================================
Files 437 437
Lines 33725 33731 +6
Branches 5265 5268 +3
==========================================
+ Hits 29089 29098 +9
+ Misses 3624 3621 -3
Partials 1012 1012 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
glevco
previously approved these changes
Dec 17, 2025
jansegre
force-pushed
the
fix/iter-mempool-runoff
branch
3 times, most recently
from
8ff9423 to
5bc5cab
Compare
1 task
jansegre
force-pushed
the
fix/iter-mempool-runoff
branch
3 times, most recently
from
310a37c to
08e9e9b
Compare
glevco
reviewed
Dec 18, 2025
jansegre
force-pushed
the
fix/iter-mempool-runoff
branch
from
08e9e9b to
74f869a
Compare
msbrogli
approved these changes
Dec 18, 2025
glevco
approved these changes
Dec 18, 2025
github-project-automation
bot
moved this from In Review (Done)
to Waiting to be deployed
in Hathor Network
2 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Issue with 100% CPU use in specific cases.
Acceptance Criteria
generate_tx_parentsso it avoids callingmempool_tips.iter_allaltogetherChecklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged