fix(nano): state API regression when requesting dict fields#1507
Merged
fix(nano): state API regression when requesting dict fields#1507
Conversation
|
| Branch | fix/nano/state-api-container-field-error |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.69 m(-2.60%)Baseline: 1.73 m | 1.56 m (92.40%) | 2.08 m (81.17%) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1507 +/- ##
==========================================
- Coverage 86.27% 86.21% -0.06%
==========================================
Files 440 440
Lines 34055 34058 +3
Branches 5326 5327 +1
==========================================
- Hits 29381 29364 -17
- Misses 3657 3670 +13
- Partials 1017 1024 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
glevco
approved these changes
Dec 8, 2025
The regression was cause by #1500 and basically causes an error at the whole request instead of just on the offending field.
b590028 to
15bad95
Compare
msbrogli
approved these changes
Dec 8, 2025
2 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The regression was caused by #1500 and basically causes an error at the whole request instead of just on the offending field.
Acceptance Criteria
TypeErrorinstead of letting it fail the whole requestChecklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged