Skip to content

chore: add soft-voided to testnet-india because of #1500#1504

Merged
jansegre merged 1 commit intomasterfrom
chore/testnet-india-pr1500-fix
Dec 3, 2025
Merged

chore: add soft-voided to testnet-india because of #1500#1504
jansegre merged 1 commit intomasterfrom
chore/testnet-india-pr1500-fix

Conversation

@jansegre
Copy link
Member

@jansegre jansegre commented Dec 3, 2025

Motivation

#1500 would invalidate an existing OCB in testnet-india and cause a reorg

Acceptance Criteria

  • add the affected transaction to SOFT_VOIDED_TX_IDS and SKIP_VERIFICATION

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@jansegre jansegre requested a review from glevco December 3, 2025 22:07
@jansegre jansegre self-assigned this Dec 3, 2025
@jansegre jansegre requested a review from msbrogli as a code owner December 3, 2025 22:07
@jansegre jansegre moved this from Todo to In Progress (Done) in Hathor Network Dec 3, 2025
@github-actions
Copy link

github-actions bot commented Dec 3, 2025

🐰 Bencher Report

Branchchore/testnet-india-pr1500-fix
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
minutes (m)
(Result Δ%)
Lower Boundary
minutes (m)
(Limit %)
Upper Boundary
minutes (m)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚷 view threshold
1.70 m
(-2.07%)Baseline: 1.73 m
1.56 m
(91.90%)
2.08 m
(81.61%)
🐰 View full continuous benchmarking report in Bencher

@jansegre jansegre mentioned this pull request Dec 3, 2025
2 tasks
@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.17%. Comparing base (a134513) to head (a930d86).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1504   +/-   ##
=======================================
  Coverage   86.16%   86.17%           
=======================================
  Files         440      440           
  Lines       34055    34055           
  Branches     5326     5326           
=======================================
+ Hits        29343    29346    +3     
+ Misses       3683     3681    -2     
+ Partials     1029     1028    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jansegre jansegre merged commit 0cc2278 into master Dec 3, 2025
11 of 14 checks passed
@jansegre jansegre deleted the chore/testnet-india-pr1500-fix branch December 3, 2025 23:07
@github-project-automation github-project-automation bot moved this from In Progress (Done) to Waiting to be deployed in Hathor Network Dec 3, 2025
@jansegre jansegre mentioned this pull request Dec 3, 2025
2 tasks
@jansegre jansegre moved this from Waiting to be deployed to Done in Hathor Network Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants