refactor: remove vertex children from metadata#1495
Merged
Conversation
a4d97c9 to
80796c9
Compare
|
| Branch | refactor/vertex-children |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.69 m(-2.58%)Baseline: 1.73 m | 1.56 m (92.39%) | 2.08 m (81.18%) |
msbrogli
previously approved these changes
Nov 25, 2025
jansegre
previously approved these changes
Nov 25, 2025
80796c9 to
196bcf6
Compare
jansegre
approved these changes
Nov 25, 2025
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1495 +/- ##
==========================================
- Coverage 86.13% 86.10% -0.03%
==========================================
Files 437 439 +2
Lines 33755 33891 +136
Branches 5275 5296 +21
==========================================
+ Hits 29076 29183 +107
- Misses 3657 3687 +30
+ Partials 1022 1021 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Dec 2, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR migrates vertex children from inside the metadata to a new standalone service, leveraging RocksDB keys to store the set of children for each vertex.
Acceptance Criteria
childrenfromTransactionMetadataand move it to a newVertexChildrenService. ABaseTransaction.get_children()method is provided for easy compatibility.childrenfrom reliable integration events.childrenonTransactionMetadata.to_json()to contain at most 100 children. This key is kept for compatibility with APIs.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged