Skip to content

refactor: remove vertex children from metadata#1495

Merged
jansegre merged 2 commits intomasterfrom
refactor/vertex-children
Nov 26, 2025
Merged

refactor: remove vertex children from metadata#1495
jansegre merged 2 commits intomasterfrom
refactor/vertex-children

Conversation

@glevco
Copy link
Contributor

@glevco glevco commented Nov 25, 2025

Motivation

This PR migrates vertex children from inside the metadata to a new standalone service, leveraging RocksDB keys to store the set of children for each vertex.

Acceptance Criteria

  • Remove children from TransactionMetadata and move it to a new VertexChildrenService. A BaseTransaction.get_children() method is provided for easy compatibility.
  • Remove children from reliable integration events.
  • Limit graphviz endpoint to display at most 100 children per node.
  • Limit children on TransactionMetadata.to_json() to contain at most 100 children. This key is kept for compatibility with APIs.
  • Add migration to move vertex children to new structure.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this Nov 25, 2025
@glevco glevco force-pushed the refactor/vertex-children branch from a4d97c9 to 80796c9 Compare November 25, 2025 16:42
@glevco glevco moved this from Todo to In Progress (Done) in Hathor Network Nov 25, 2025
@glevco glevco changed the title Refactor/vertex children refactor: remove vertex children from metadata Nov 25, 2025
@github-actions
Copy link

github-actions bot commented Nov 25, 2025

🐰 Bencher Report

Branchrefactor/vertex-children
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
minutes (m)
(Result Δ%)
Lower Boundary
minutes (m)
(Limit %)
Upper Boundary
minutes (m)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚷 view threshold
1.69 m
(-2.58%)Baseline: 1.73 m
1.56 m
(92.39%)
2.08 m
(81.18%)
🐰 View full continuous benchmarking report in Bencher

msbrogli
msbrogli previously approved these changes Nov 25, 2025
jansegre
jansegre previously approved these changes Nov 25, 2025
@github-project-automation github-project-automation bot moved this from In Progress (Done) to In Review (WIP) in Hathor Network Nov 25, 2025
@glevco glevco force-pushed the refactor/vertex-children branch from 80796c9 to 196bcf6 Compare November 25, 2025 20:24
@glevco glevco dismissed stale reviews from msbrogli and jansegre via 9f37644 November 25, 2025 22:04
@glevco glevco moved this from In Review (WIP) to In Review (Done) in Hathor Network Nov 26, 2025
@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

❌ Patch coverage is 80.34682% with 34 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.10%. Comparing base (8714656) to head (9f37644).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
hathor/transaction/storage/rocksdb_storage.py 18.75% 26 Missing ⚠️
hathor/graphviz.py 50.00% 5 Missing ⚠️
hathor/transaction/storage/cache_storage.py 80.00% 1 Missing ⚠️
...tion/storage/migrations/migrate_vertex_children.py 90.90% 1 Missing ⚠️
hathor/transaction/transaction.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1495      +/-   ##
==========================================
- Coverage   86.13%   86.10%   -0.03%     
==========================================
  Files         437      439       +2     
  Lines       33755    33891     +136     
  Branches     5275     5296      +21     
==========================================
+ Hits        29076    29183     +107     
- Misses       3657     3687      +30     
+ Partials     1022     1021       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jansegre jansegre merged commit fb72843 into master Nov 26, 2025
10 of 14 checks passed
@jansegre jansegre deleted the refactor/vertex-children branch November 26, 2025 20:37
@github-project-automation github-project-automation bot moved this from In Review (Done) to Waiting to be deployed in Hathor Network Nov 26, 2025
This was referenced Dec 2, 2025
@jansegre jansegre moved this from Waiting to be deployed to Done in Hathor Network Dec 4, 2025
@jansegre jansegre changed the title refactor: remove vertex children from metadata refactor: remove vertex children from metadata Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants