Merged
Conversation
jansegre
approved these changes
Nov 20, 2025
|
| Branch | fix/get-state-serialization |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.79 m(+3.12%)Baseline: 1.73 m | 1.56 m (87.28%) | 2.08 m (85.93%) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1492 +/- ##
==========================================
+ Coverage 86.12% 86.15% +0.02%
==========================================
Files 437 437
Lines 33758 33757 -1
Branches 5275 5274 -1
==========================================
+ Hits 29074 29083 +9
+ Misses 3660 3654 -6
+ Partials 1024 1020 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
msbrogli
approved these changes
Nov 21, 2025
This was referenced Dec 2, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The nanocontract state API was not properly serializing return values from view method calls. When calling view methods that returned complex types (like tuples), the serialization was only checking if the value was bytes and converting to hex, but didn't handle other types correctly.
Acceptance Criteria
parse_nc_method_callfunction now returns the Method object to enable proper serializationChecklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged