Skip to content

fix(nano): fix nc creation API#1487

Merged
jansegre merged 1 commit intomasterfrom
fix/nc-creation-api
Nov 25, 2025
Merged

fix(nano): fix nc creation API#1487
jansegre merged 1 commit intomasterfrom
fix/nc-creation-api

Conversation

@glevco
Copy link
Contributor

@glevco glevco commented Nov 11, 2025

Motivation

There's a bug in the NC creation API where sometimes it displays less items than the requested count, even though more items are available. This was reported by @pedroferreira1.

The problem was that there was a filter after pagination logic, where items for contracts created by other contracts would be filtered out after the collection of count items.

Acceptance Criteria

  • Fix filter after pagination logic.
  • Remove unused method.
  • Add test covering the issue.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this Nov 11, 2025
@glevco glevco moved this from Todo to In Progress (WIP) in Hathor Network Nov 11, 2025
@glevco glevco moved this from In Progress (WIP) to In Progress (Done) in Hathor Network Nov 11, 2025
@github-actions
Copy link

github-actions bot commented Nov 11, 2025

🐰 Bencher Report

Branchfix/nc-creation-api
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
minutes (m)
(Result Δ%)
Lower Boundary
minutes (m)
(Limit %)
Upper Boundary
minutes (m)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚷 view threshold
1.75 m
(+1.21%)Baseline: 1.73 m
1.56 m
(88.92%)
2.08 m
(84.35%)
🐰 View full continuous benchmarking report in Bencher

msbrogli
msbrogli previously approved these changes Nov 12, 2025
@glevco glevco moved this from In Progress (Done) to In Review (WIP) in Hathor Network Nov 12, 2025
@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.13%. Comparing base (c8434eb) to head (8714656).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1487      +/-   ##
==========================================
+ Coverage   86.12%   86.13%   +0.01%     
==========================================
  Files         437      437              
  Lines       33757    33755       -2     
  Branches     5274     5275       +1     
==========================================
+ Hits        29073    29076       +3     
+ Misses       3662     3657       -5     
  Partials     1022     1022              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

# Conflicts:
#	hathor_tests/resources/nanocontracts/test_nc_creation.py
@jansegre jansegre merged commit c456da7 into master Nov 25, 2025
6 of 8 checks passed
@jansegre jansegre deleted the fix/nc-creation-api branch November 25, 2025 19:54
@github-project-automation github-project-automation bot moved this from In Review (WIP) to Waiting to be deployed in Hathor Network Nov 25, 2025
This was referenced Dec 2, 2025
@jansegre jansegre moved this from Waiting to be deployed to Done in Hathor Network Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants