Conversation
|
| Branch | fix/nc-creation-api |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.75 m(+1.21%)Baseline: 1.73 m | 1.56 m (88.92%) | 2.08 m (84.35%) |
msbrogli
previously approved these changes
Nov 12, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1487 +/- ##
==========================================
+ Coverage 86.12% 86.13% +0.01%
==========================================
Files 437 437
Lines 33757 33755 -2
Branches 5274 5275 +1
==========================================
+ Hits 29073 29076 +3
+ Misses 3662 3657 -5
Partials 1022 1022 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
# Conflicts: # hathor_tests/resources/nanocontracts/test_nc_creation.py
1983de9 to
8714656
Compare
msbrogli
approved these changes
Nov 25, 2025
jansegre
approved these changes
Nov 25, 2025
This was referenced Dec 2, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
There's a bug in the NC creation API where sometimes it displays less items than the requested
count, even though more items are available. This was reported by @pedroferreira1.The problem was that there was a filter after pagination logic, where items for contracts created by other contracts would be filtered out after the collection of
countitems.Acceptance Criteria
Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged